Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android refactor #263

Merged
merged 6 commits into from Mar 22, 2016
Merged

Android refactor #263

merged 6 commits into from Mar 22, 2016

Commits on Mar 22, 2016

  1. Rename Servo build dependency sls files

    This change groups the various sls files that set up the Servo build
    environment into a single folder to:
     - make their purpose more clear in the top.sls file
     - make it easier to add auxiliary files (i.e. map.jinja)
    
    Also, don't install the Servo build dependencies on the Buildbot master,
    but make sure to keep git installed to update the Salt file tree.
    aneeshusa committed Mar 22, 2016
  2. Upgrade to SHA512 hashes everywhere

    Use a SHA512 hash instead of a SHA1 hash to verify the B2G download.
    Update the style guide.
    aneeshusa committed Mar 22, 2016
  3. Make Android states more robust to version updates

    Use separate directories for separate versions of the
    SDK, NDK, and toolchain, and use symlinks to point to the current
    versions. This is more robust for a few reasons:
     - Partially-completed upgrades to new versions won't touch
       existing versions on the disk
     - The symlinks aren't updated until the respective new version is
       completely installed, allowing for more transactional updates.
     - The symlinks also allow for constant paths in the bash_profile file
       and the buildbot config, which means less moving parts to break.
       In particular, the relevant buildbot config is on the master, and
       using symlinks makes it unnecessary to use Salt orchestration to
       gate changes to the master buildbot config on changes on the cross
       builders.
    
    Ideally, these states would also use file.directory with clean: True
    to clean out old versions of the SDK, NDK, and toolchain, but I wasn't
    able to get this working properly yet (the just-downloaded files would
    keep getting cleaned away).
    
    This also eliminates our use of cmd.wait, which was recently put on the
    deprecation path in Salt, and replaces it with cmd.run + creates: True.
    aneeshusa committed Mar 22, 2016
  4. Remove .bash_profile setup

    The buildbot configuration already sets the correct environment
    variables for Android builds, so it's unnecessary to set them via
    .bash_profile.
    aneeshusa committed Mar 22, 2016
  5. Drop to the warning log level for Travis

    archive.extracted is fairly loud because each extracted file is listed
    both in INFO log level output and the highstate summary.
    This gets around exceeding Travis's 4MB log length limit.
    aneeshusa committed Mar 22, 2016
You can’t perform that action at this time.