Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate ARM rootfs urls to nest version inside name #268
Conversation
This allows updating each of the rootfs tarballs separately.
|
@bors-servo r+ |
|
|
…ergstrom Update ARM rootfs urls to nest version inside name This allows updating each of the rootfs tarballs separately. Note that the exact format of the URLs is open to some bikeshedding, but I recommend this for the following reasons: - Switching the version and the name (so that version is inside name) lets you update the tarballs separately - Keeping the version in the actual file name lets you download different versions without them clobbering each other on disk cc @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/268) <!-- Reviewable:end -->
|
|
|
@larsbergstrom Wait, did you update the URLs in the S3 bucket to match? I'm not seeing the updated URLs and it failed on Travis too; it only passed because of #274. |
|
hrm, I comletely misread Is that what we want? Doesn't /me revokes own r+ privs |
|
Sorry I wasn't more explicit about needing to update the S3 bucket! You're right about the |
|
@aneeshusa no need to apologize - I need to pay better attention. Thanks! We'll can avoid highstate'ing until the new PR lands and I do update the s3 bucket. CC @edunham |
See this comment for context: servo#268 (comment)
…, r=larsbergstrom Remove extraneous .tgz to fix ARM rootfs downloads See this comment for context: #268 (comment) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/278) <!-- Reviewable:end -->
aneeshusa commentedMar 23, 2016
This allows updating each of the rootfs tarballs separately.
Note that the exact format of the URLs is open to some bikeshedding, but I recommend this for the following reasons:
cc @larsbergstrom
This change is