Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARM rootfs urls to nest version inside name #268

Merged
merged 1 commit into from Mar 25, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Mar 23, 2016

This allows updating each of the rootfs tarballs separately.

Note that the exact format of the URLs is open to some bikeshedding, but I recommend this for the following reasons:

  • Switching the version and the name (so that version is inside name) lets you update the tarballs separately
  • Keeping the version in the actual file name lets you download different versions without them clobbering each other on disk

cc @larsbergstrom


This change is Reviewable

This allows updating each of the rootfs tarballs separately.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

📌 Commit 5856d1a has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

Testing commit 5856d1a with merge 2c73ca6...

bors-servo added a commit that referenced this pull request Mar 25, 2016
…ergstrom

Update ARM rootfs urls to nest version inside name

This allows updating each of the rootfs tarballs separately.

Note that the exact format of the URLs is open to some bikeshedding, but I recommend this for the following reasons:
  - Switching the version and the name (so that version is inside name) lets you update the tarballs separately
  - Keeping the version in the actual file name lets you download different versions without them clobbering each other on disk

cc @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/268)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 5856d1a into servo:master Mar 25, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Testing commit 5856d1a with merge 2c73ca6...
Details
@aneeshusa
Copy link
Member Author

aneeshusa commented Mar 25, 2016

@larsbergstrom Wait, did you update the URLs in the S3 bucket to match? I'm not seeing the updated URLs and it failed on Travis too; it only passed because of #274.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

hrm, I comletely misread https://servo-rust.s3.amazonaws.com/ARM/{{ target.download_name }}/{{ target.version }}/{{ target.download_name }}-{{ target.version }}.tgz

Is that what we want? Doesn't target.download_name already have the .tgz on it? Urgh, I was so carefully checking that all of the removed bits were present in the new bits that I missed what the new bits actually said.

/me revokes own r+ privs

@aneeshusa
Copy link
Member Author

aneeshusa commented Mar 25, 2016

Sorry I wasn't more explicit about needing to update the S3 bucket!

You're right about the .tgz extension; I meant to do that and forgot to update it when I moved it over to the map.jinja file. Let me open another PR to fix it.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

@aneeshusa no need to apologize - I need to pay better attention. Thanks! We'll can avoid highstate'ing until the new PR lands and I do update the s3 bucket.

CC @edunham

aneeshusa added a commit to aneeshusa/servo-saltfs that referenced this pull request Mar 25, 2016
bors-servo added a commit that referenced this pull request Mar 25, 2016
…, r=larsbergstrom

Remove extraneous .tgz to fix ARM rootfs downloads

See this comment for context:
#268 (comment)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/278)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.