You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Do we still need to install git explicitly, or will it get pulled in as a dependency or fulfilled by python-pygit2? I only added it to support the existing workflow of manually pulling, so let's remove it if it's not needed.
Also, I think it also makes sense to move this state to a new folder + file salt/master.sls instead, to make its purpose more clear, and get rid of the git folder.
Actually, the Salt docs note that python-pygit2 isn't available in the Ubuntu Trusty repos, and Travis corroborates this. It does seem to be available from 15.10 onwards, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.saltstack.com/en/2015.5/topics/tutorials/gitfs.html says it's the preferred method.
It looks like we're not managing any of the salt-master config within salt itself, so this dependency is the only change for #264
This change is