Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Master needs a python git package for gitfs#271

Closed
edunham wants to merge 1 commit intoservo:masterfrom
edunham:gitfs
Closed

Master needs a python git package for gitfs#271
edunham wants to merge 1 commit intoservo:masterfrom
edunham:gitfs

Conversation

@edunham
Copy link
Contributor

@edunham edunham commented Mar 23, 2016

https://docs.saltstack.com/en/2015.5/topics/tutorials/gitfs.html says it's the preferred method.

It looks like we're not managing any of the salt-master config within salt itself, so this dependency is the only change for #264


This change is Reviewable

@aneeshusa
Copy link
Contributor

Do we still need to install git explicitly, or will it get pulled in as a dependency or fulfilled by python-pygit2? I only added it to support the existing workflow of manually pulling, so let's remove it if it's not needed.

Also, I think it also makes sense to move this state to a new folder + file salt/master.sls instead, to make its purpose more clear, and get rid of the git folder.

@aneeshusa
Copy link
Contributor

Actually, the Salt docs note that python-pygit2 isn't available in the Ubuntu Trusty repos, and Travis corroborates this. It does seem to be available from 15.10 onwards, though.

@edunham
Copy link
Contributor Author

edunham commented Mar 24, 2016

Might as well just use GitPython, then.

Ubuntu 14.04 LTS and Debian Wheezy (7.x) also have a compatible version packaged:
$ sudo apt-get install python-git

Amended commit, and rebased onto current master branch to pull in the workaround for the Travis intermittents.

@edunham edunham changed the title Master needs pygit2 for gitfs Master needs a python git package for gitfs Mar 24, 2016
@edunham
Copy link
Contributor Author

edunham commented Mar 25, 2016

Closing because I'm adding some other saltmaster-specific states and renaming the git directory for another PR, and I'll stick this change into there

@edunham edunham closed this Mar 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants