Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master needs a python git package for gitfs #271

Closed
wants to merge 1 commit into from
Closed

Conversation

@edunham
Copy link
Contributor

edunham commented Mar 23, 2016

https://docs.saltstack.com/en/2015.5/topics/tutorials/gitfs.html says it's the preferred method.

It looks like we're not managing any of the salt-master config within salt itself, so this dependency is the only change for #264


This change is Reviewable

@aneeshusa
Copy link
Member

aneeshusa commented Mar 23, 2016

Do we still need to install git explicitly, or will it get pulled in as a dependency or fulfilled by python-pygit2? I only added it to support the existing workflow of manually pulling, so let's remove it if it's not needed.

Also, I think it also makes sense to move this state to a new folder + file salt/master.sls instead, to make its purpose more clear, and get rid of the git folder.

@aneeshusa
Copy link
Member

aneeshusa commented Mar 23, 2016

Actually, the Salt docs note that python-pygit2 isn't available in the Ubuntu Trusty repos, and Travis corroborates this. It does seem to be available from 15.10 onwards, though.

@edunham edunham force-pushed the edunham:gitfs branch from bfd0a53 to e570b7a Mar 24, 2016
https://docs.saltstack.com/en/2015.5/topics/tutorials/gitfs.html says it's the
preferred method. Working on #264.
@edunham edunham force-pushed the edunham:gitfs branch from e570b7a to 639dae9 Mar 24, 2016
@edunham
Copy link
Contributor Author

edunham commented Mar 24, 2016

Might as well just use GitPython, then.

Ubuntu 14.04 LTS and Debian Wheezy (7.x) also have a compatible version packaged:
$ sudo apt-get install python-git

Amended commit, and rebased onto current master branch to pull in the workaround for the Travis intermittents.

@edunham edunham changed the title Master needs pygit2 for gitfs Master needs a python git package for gitfs Mar 24, 2016
@edunham
Copy link
Contributor Author

edunham commented Mar 25, 2016

Closing because I'm adding some other saltmaster-specific states and renaming the git directory for another PR, and I'll stick this change into there

@edunham edunham closed this Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.