Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous .tgz to fix ARM rootfs downloads #278

Merged

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Mar 25, 2016

See this comment for context:
#268 (comment)


This change is Reviewable

See this comment for context:
#268 (comment)
@aneeshusa
Copy link
Member Author

aneeshusa commented Mar 25, 2016

Let's wait to merge until after S3 is updated and we've carefully examined the Travis logs for the cross builder this time.

cc @larsbergstrom

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

[larsberg@lbergstrom saltfs]$ s3cmd cp s3://servo-rust/ARM/v1/armhf-trusty-libs.tgz s3://servo-rust/ARM/armhf-trusty-libs/v1/armhf-trusty-libs.tgz
remote copy: 's3://servo-rust/ARM/v1/armhf-trusty-libs.tgz' -> 's3://servo-rust/ARM/armhf-trusty-libs/v1/armhf-trusty-libs.tgz'
[larsberg@lbergstrom saltfs]$ s3cmd cp s3://servo-rust/ARM/v1/arm64-trusty-libs.tgz s3://servo-rust/ARM/arm64-trusty-libs/v1/arm64-trusty-libs.tgz
remote copy: 's3://servo-rust/ARM/v1/arm64-trusty-libs.tgz' -> 's3://servo-rust/ARM/arm64-trusty-libs/v1/arm64-trusty-libs.tgz'
[larsberg@lbergstrom saltfs]$ 
@aneeshusa
Copy link
Member Author

aneeshusa commented Mar 25, 2016

@larsbergstrom That's still not quite right, double-check the changes I made. (Missing a version string in the filename).

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

Wow :-)

[larsberg@lbergstrom saltfs]$ s3cmd cp s3://servo-rust/ARM/v1/arm64-trusty-libs.tgz s3://servo-rust/ARM/arm64-trusty-libs/v1/arm64-trusty-libs-v1.tgz
remote copy: 's3://servo-rust/ARM/v1/arm64-trusty-libs.tgz' -> 's3://servo-rust/ARM/arm64-trusty-libs/v1/arm64-trusty-libs-v1.tgz'
[larsberg@lbergstrom saltfs]$ s3cmd cp s3://servo-rust/ARM/v1/armhf-trusty-libs.tgz s3://servo-rust/ARM/armhf-trusty-libs/v1/armhf-trusty-libs-v1.tgz
remote copy: 's3://servo-rust/ARM/v1/armhf-trusty-libs.tgz' -> 's3://servo-rust/ARM/armhf-trusty-libs/v1/armhf-trusty-libs-v1.tgz'
[larsberg@lbergstrom saltfs]$ 
@aneeshusa
Copy link
Member Author

aneeshusa commented Mar 25, 2016

Thanks, looks like you uploaded it just in time for the Travis cross build to pick it up. (Please double check the logs to verify this.)

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 25, 2016

@bors-servo r+

Confirmed in the logs that they both downloaded & extracted fine :-)

@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

📌 Commit 52fef41 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

Testing commit 52fef41 with merge 9e6550c...

bors-servo added a commit that referenced this pull request Mar 25, 2016
…, r=larsbergstrom

Remove extraneous .tgz to fix ARM rootfs downloads

See this comment for context:
#268 (comment)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/278)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 25, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 52fef41 into servo:master Mar 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.