Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprust bindgen support #279
Merged
rust bindgen support #279
Conversation
|
Do we hand out the same GH webhook secret for every repo, or do we generate a new one for each repo? |
|
Misclick. -_- |
|
@aneeshusa We only have one hook right now. We could create and store new tokens for each repo (homu definitely supports per-repo tokens!), but I think I'd really like to get it installed and integrated as a first-class app via GitHub so that interaction through salt is not required to add a new repo. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 28, 2016
rust bindgen support r? @Manishearth @edunham I'm still not sure of the best way to handle the fact that we need to hand out a GH webhook secret to arbitrary people to set this up. I suspect we will need to set up homu.servo.org at some point. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/279) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedMar 26, 2016
r? @Manishearth @edunham
I'm still not sure of the best way to handle the fact that we need to hand out a GH webhook secret to arbitrary people to set this up. I suspect we will need to set up homu.servo.org at some point.
This change is