Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dev flag to mach build commands #28

Merged
merged 1 commit into from May 14, 2015
Merged

Add --dev flag to mach build commands #28

merged 1 commit into from May 14, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented May 6, 2015

This is a no-op right now, but it will be necessary if servo/servo#5964 lands. r? @larsbergstrom
@mbrubeck mbrubeck force-pushed the mbrubeck:debug branch from 2a0d0b0 to 808e050 May 7, 2015
@mbrubeck mbrubeck changed the title Add --debug flag to mach build commands Add --dev flag to mach build commands May 7, 2015
@mbrubeck
Add --dev flag to mach build commands
808e050
@larsberg
Copy link

larsberg commented May 8, 2015

I think you've got the wrong guy, maybe you want @larsbergstrom https://github.com/larsbergstrom?
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 8, 2015

Hrm, this brings up the fact that we never did turn on the release builders. Maybe we should be building all of these with --release instead? I'm a little scared of the fact that we're not testing the build we should be shipping.
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 8, 2015

Oops, sorry @larsberg! Feel free to unsubscribe from this issue. @larsbergstrom uses that username on some other forums, which is why I got mixed up.

@larsbergstrom: Yes, we could change at least one of these to --release, if we have the time or capacity to add separate release builders. But we'd lose coverage of debug_assert and overflow checking during any tests that are no longer run on debug builds.

Note: I updated this PR to use --dev instead of --debug, to reflect changes in #5964. But this means it's no longer a no-op on Servo master, so we shouldn't deploy this yet.
@mbrubeck mbrubeck changed the title Add --dev flag to mach build commands DO NOT MERGE: Add --dev flag to mach build commands May 8, 2015
@mbrubeck mbrubeck mentioned this pull request May 9, 2015
Closed
mbrubeck added a commit to mbrubeck/servo that referenced this pull request May 12, 2015
@mbrubeck
Add a no-op --dev option to the mach build command.
2dc0481 
This is part of servo#5965.  It needs to land before the rest of that PR, so we can
land servo/saltfs#28 without breaking automated builds for other PRs.
@mbrubeck mbrubeck mentioned this pull request May 12, 2015
Merged
bors-servo pushed a commit to servo/servo that referenced this pull request May 12, 2015
bors-servo
Auto merge of #6023 - mbrubeck:dev-nop, r=larsbergstrom
f4c1768 
This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6023)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request May 12, 2015
bors-servo
Auto merge of #6023 - mbrubeck:dev-nop, r=larsbergstrom
Loading status checks…
3e69bf8 
This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6023)
<!-- Reviewable:end -->
@mbrubeck mbrubeck changed the title DO NOT MERGE: Add --dev flag to mach build commands Add --dev flag to mach build commands May 12, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 12, 2015

This is ready to merge now that servo/servo#6023 has landed.
@mbrubeck mbrubeck mentioned this pull request May 13, 2015
Merged
larsbergstrom added a commit that referenced this pull request May 14, 2015
@larsbergstrom
Merge pull request #28 from mbrubeck/debug
dfb0aad 
Add --dev flag to mach build commands
@larsbergstrom larsbergstrom merged commit dfb0aad into servo:master May 14, 2015
bors-servo pushed a commit to servo/servo that referenced this pull request May 14, 2015
bors-servo
Auto merge of #6038 - mbrubeck:jinankjain-Bug#5933, r=mbrubeck
Loading status checks…
c0d8488 
Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is @jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6038)
<!-- Reviewable:end -->
Manishearth pushed a commit that referenced this pull request Mar 9, 2016
@barosl
Display the "approved" status in the queue page
4b79553 
This status does not really exist. It is just an alias for (status == ''
and approved_by != '').

Fixes #28.
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
@mbrubeck
servo: Merge #6023 - Add a no-op --dev option to the mach build comma…
67fa10a 
…nd (from mbrubeck:dev-nop); r=larsbergstrom

This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? @larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: 3e69bf8cd23caa5b691e42141d1111070ff831f5
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this pull request Jun 12, 2017
@jinankjain
servo: Merge #6038 - Add --dev option to mach build (from mbrubeck:ji…
59ab94e 
…nankjain-Bug#5933); r=mbrubeck

Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is @jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

Source-Repo: https://github.com/servo/servo
Source-Revision: c0d8488b719ea72e73e435618e015c2f705853cc
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
@marco-c
servo: Merge #6023 - Add a no-op --dev option to the mach build comma…
c5f2b49 
…nd (from mbrubeck:dev-nop); r=larsbergstrom

This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: 3e69bf8cd23caa5b691e42141d1111070ff831f5

UltraBlame original commit: c14625d615b36e858f40afd208c14c98129f3853
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 30, 2019
@marco-c
servo: Merge #6038 - Add --dev option to mach build (from mbrubeck:ji…
25cf23c 
…nankjain-Bug#5933); r=mbrubeck

Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

Source-Repo: https://github.com/servo/servo
Source-Revision: c0d8488b719ea72e73e435618e015c2f705853cc

UltraBlame original commit: 8898638c645eb2f411b9accfa9e93b3ead6b7fa8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #6023 - Add a no-op --dev option to the mach build comma…
81d8f15 
…nd (from mbrubeck:dev-nop); r=larsbergstrom

This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: 3e69bf8cd23caa5b691e42141d1111070ff831f5

UltraBlame original commit: c14625d615b36e858f40afd208c14c98129f3853
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #6038 - Add --dev option to mach build (from mbrubeck:ji…
65afbcf 
…nankjain-Bug#5933); r=mbrubeck

Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

Source-Repo: https://github.com/servo/servo
Source-Revision: c0d8488b719ea72e73e435618e015c2f705853cc

UltraBlame original commit: 8898638c645eb2f411b9accfa9e93b3ead6b7fa8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #6023 - Add a no-op --dev option to the mach build comma…
d156b47 
…nd (from mbrubeck:dev-nop); r=larsbergstrom

This is part of #5965.  It needs to land before the rest of that PR, so we can land servo/saltfs#28 without breaking automated builds for other PRs. r? larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: 3e69bf8cd23caa5b691e42141d1111070ff831f5

UltraBlame original commit: c14625d615b36e858f40afd208c14c98129f3853
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #6038 - Add --dev option to mach build (from mbrubeck:ji…
2dd7eb9 
…nankjain-Bug#5933); r=mbrubeck

Require either `--dev` or `--release`, unless a default build.mode is set in `.servobuild`.  This is jinankjain's patch from #5965, rebased onto master.  It is already reviewed, and only waiting for servo/saltfs#28 to be deployed.

Source-Repo: https://github.com/servo/servo
Source-Revision: c0d8488b719ea72e73e435618e015c2f705853cc

UltraBlame original commit: 8898638c645eb2f411b9accfa9e93b3ead6b7fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mbrubeck @larsberg @larsbergstrom
You can’t perform that action at this time.