Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle multiple (redundant) masters #284
Merged
Conversation
Update the Salt states to handle multiple minions that host masters. This will allow us to easily enter redundant multimaster mode to handle switching over our master from Linode to EC2, by using separate IDs for each machine instead of trying to reuse the `servo-master` ID.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 29, 2016
Handle multiple (redundant) masters Update the Salt states to handle multiple minions that host masters. This will allow us to easily enter redundant multimaster mode to handle switching over our master from Linode to EC2, by using separate IDs for each machine instead of trying to reuse the `servo-master` ID. See #281 (comment) for more details. I haven't updated the `common/map.jinja` file yet; are we still using these hostnames in the `/etc/hosts` file or is everything happening via DNS lookups? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/284) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 4, 2016
…strom Target servo-master\d+ with PCRE in the top file This fixes the targeting for servo-master\d+ so that the extra states are actually applied. I noticed this while reviewing the travis builds for #291. This was missed in both #284 and #285! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/292) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMar 29, 2016
Update the Salt states to handle multiple minions that host masters.
This will allow us to easily enter redundant multimaster mode to handle
switching over our master from Linode to EC2, by using separate IDs for
each machine instead of trying to reuse the
servo-masterID.See #281 (comment) for more details.
I haven't updated the
common/map.jinjafile yet; are we still using these hostnames in the/etc/hostsfile or is everything happening via DNS lookups?This change is