Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-engage servo-linux-cross1 on Travis #291
Merged
+0
−2
Conversation
bors-servo
added a commit
that referenced
this pull request
Apr 4, 2016
…strom Target servo-master\d+ with PCRE in the top file This fixes the targeting for servo-master\d+ so that the extra states are actually applied. I noticed this while reviewing the travis builds for #291. This was missed in both #284 and #285! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/292) <!-- Reviewable:end -->
|
@bors-servo r+ |
|
|
|
|
|
|
Upstream has released new packages for Ubuntu Trusty which resolve the installation conflicts encountered when installing the ARM g++ packages. See https://bugs.launchpad.net/ubuntu/+source/gcc-4.8-armhf-cross/+bug/1557205/comments/16 for a comment confirming release of the upstream fix. This reverts commit aa84355.
aneeshusa
force-pushed the
aneeshusa:reenable-cross-on-travis-after-fix-for-arm-g++-packages
branch
from
d32e349
to
ea28291
|
Rebased. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 5, 2016
…-arm-g++-packages, r=larsbergstrom Re-engage servo-linux-cross1 on Travis Upstream has released new packages for Ubuntu Trusty which resolve the installation conflicts encountered when installing the ARM g++ packages. See https://bugs.launchpad.net/ubuntu/+source/gcc-4.8-armhf-cross/+bug/1557205/comments/16 for a comment confirming release of the upstream fix. This reverts commit aa84355 which was part of #274. Closes #280. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/291) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 3, 2016
Upstream has released new packages for Ubuntu Trusty which resolve
the installation conflicts encountered when installing the ARM g++ packages.
See https://bugs.launchpad.net/ubuntu/+source/gcc-4.8-armhf-cross/+bug/1557205/comments/16
for a comment confirming release of the upstream fix.
This reverts commit aa84355 which was part of #274.
Closes #280.
This change is