Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTarget servo-master\d+ with PCRE in the top file #292
Merged
Conversation
We now number the servo-master IDs like other machines, so use PCRE targeting to match the `servo-master\d+` pattern for both states and the Travis test pillars. This ensures the relevant pillars are available to master machines and the master-specific states are applied.
aneeshusa
force-pushed the
aneeshusa:fix-servo-master-top-match
branch
from
77b1a6c
to
00f2802
|
r? @edunham I think there were a couple of these edits you were also looking at after the moveover? |
|
Namely, does this also need: |
|
I asked about it before, but I think now we're actually trying to get rid of that entire list (see #287). If anything is using those hosts entries for lookups instead of DNS, it's a bug. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 4, 2016
…strom Target servo-master\d+ with PCRE in the top file This fixes the targeting for servo-master\d+ so that the extra states are actually applied. I noticed this while reviewing the travis builds for #291. This was missed in both #284 and #285! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/292) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 3, 2016
This fixes the targeting for servo-master\d+ so that the extra states
are actually applied.
I noticed this while reviewing the travis builds for #291.
This was missed in both #284 and #285!
This change is