Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite #295

Merged
merged 3 commits into from Apr 5, 2016
Merged

Add test suite #295

merged 3 commits into from Apr 5, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Apr 4, 2016

Currently checks for executable shebangs and trailing whitespace.
Adds a dispatch script to run on Travis.


This change is Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented Apr 4, 2016

The latest upstream changes (presumably #294) made this pull request unmergeable. Please resolve the merge conflicts.

@aneeshusa aneeshusa force-pushed the aneeshusa:add-test-suite branch from eb94554 to 0ec8dd8 Apr 4, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Apr 4, 2016

Rebased on top of the latest master, the homu update also fixed a whitespace bug.

@aneeshusa aneeshusa force-pushed the aneeshusa:add-test-suite branch 2 times, most recently from 8cb16cc to 455d32c Apr 4, 2016
aneeshusa added 2 commits Apr 4, 2016
Start a small test suite in Python 3.
Add a test to check executable shebangs.
@aneeshusa aneeshusa force-pushed the aneeshusa:add-test-suite branch 3 times, most recently from c061164 to 968692a Apr 4, 2016
.travis.yml Outdated
- env: SALT_NODE_ID=test # Not a Salt node, runs test suite instead
os: linux
sudo: required
dist: trusy

This comment has been minimized.

Copy link
@wafflespeanut

wafflespeanut Apr 5, 2016

Member

um, trusty? :)

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Apr 5, 2016

Author Member

Oops, thanks!

Use a dispatch script to direct Travis to either run a Salt highstate
for most nodes, or the test script for the test node.

This reduces the amount of project-specific configuration in .travis.yml
and moves it into a separate file.
@aneeshusa aneeshusa force-pushed the aneeshusa:add-test-suite branch from 968692a to 39bfbae Apr 5, 2016
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 5, 2016

Reviewed 9 of 9 files at r1.
Review status: 7 of 12 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 5, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2016

📌 Commit 39bfbae has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2016

Testing commit 39bfbae with merge ce8769f...

bors-servo added a commit that referenced this pull request Apr 5, 2016
Add test suite

Currently checks for executable shebangs and trailing whitespace.
Adds a dispatch script to run on Travis.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/295)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 5, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 39bfbae into servo:master Apr 5, 2016
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 7 of 12 files reviewed, 1 unresolved discussion
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa
Copy link
Member Author

aneeshusa commented Apr 5, 2016

I updated the Salt install instructions and mentioned the test script on the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.