Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd check for Python 3.5+ in test script #299
Merged
+6
−0
Conversation
|
|
The test script uses features introduced in Python 3.5 (namely os.path.commonpath), but the shebang only specifies python3. Because Python3.5 is fairly new, it's likely that python3 is not yet Python 3.5 (or later) for many people, so explicitly check for this. This occured on Travis, requiring an explicit 'python: 3.5' config, which is what spurred this commit.
aneeshusa
force-pushed the
aneeshusa:require-python-3.5-for-test-script
branch
from
4f4d17c
to
702cae5
|
Rebased. |
|
@bors-servo r+ Relatedly, ought we be running |
|
|
bors-servo
added a commit
that referenced
this pull request
May 5, 2016
…edunham Add check for Python 3.5+ in test script The test script uses features introduced in Python 3.5 (namely os.path.commonpath), but the shebang only specifies python3. Because Python3.5 is fairly new, it's likely that python3 is not yet Python 3.5 (or later) for many people, so explicitly check for this. This occured on Travis, requiring an explicit 'python: 3.5' config, which is what spurred this commit. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/299) <!-- Reviewable:end -->
|
@edunham test.py is getting run on Travis, via the |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 5, 2016
The test script uses features introduced in Python 3.5 (namely
os.path.commonpath), but the shebang only specifies python3. Because
Python3.5 is fairly new, it's likely that python3 is not yet Python 3.5
(or later) for many people, so explicitly check for this.
This occured on Travis, requiring an explicit 'python: 3.5' config,
which is what spurred this commit.
This change is