This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Add test to check if Nginx is serving requests#308
Merged
bors-servo merged 1 commit intoservo:masterfrom May 5, 2016
Merged
Conversation
aneeshusa
force-pushed
the
add-nginx-test
branch
from
19c3fd9 to
66bc4f5
Compare
urllib's error handling is not very helpful for this test, but I'm using it in an effort to avoid extra dependencies. This only checks if Nginx is alive and returning requests, not whether the HTTP status codes indicate success. The reason for this is that the test pillars we have in the repo are not valid, causing Buildbot and Homu to die after starting, and thus Nginx returns 502 Bad Gateway errors when it tries to reverse proxy requests. Enable the test on Travis as well.
aneeshusa
force-pushed
the
add-nginx-test
branch
from
66bc4f5 to
40cd1f7
Compare
Contributor
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 40cd1f7 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
May 5, 2016
Add test to check if Nginx is serving requests urllib's error handling is not very helpful for this test, but I'm using it in an effort to avoid extra dependencies. This only checks if Nginx is alive and returning requests, not whether the HTTP status codes indicate success. The reason for this is that the test pillars we have in the repo are not valid, causing Buildbot and Homu to die after starting, and thus Nginx returns 502 Bad Gateway errors when it tries to reverse proxy requests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/308) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.
This change is