Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test to check if Nginx is serving requests #308
Merged
Conversation
urllib's error handling is not very helpful for this test, but I'm using it in an effort to avoid extra dependencies. This only checks if Nginx is alive and returning requests, not whether the HTTP status codes indicate success. The reason for this is that the test pillars we have in the repo are not valid, causing Buildbot and Homu to die after starting, and thus Nginx returns 502 Bad Gateway errors when it tries to reverse proxy requests. Enable the test on Travis as well.
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 5, 2016
Add test to check if Nginx is serving requests urllib's error handling is not very helpful for this test, but I'm using it in an effort to avoid extra dependencies. This only checks if Nginx is alive and returning requests, not whether the HTTP status codes indicate success. The reason for this is that the test pillars we have in the repo are not valid, causing Buildbot and Homu to die after starting, and thus Nginx returns 502 Bad Gateway errors when it tries to reverse proxy requests. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/308) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 7, 2016
urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.
This change is