Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Add test to check if Nginx is serving requests#308

Merged
bors-servo merged 1 commit intoservo:masterfrom
aneeshusa:add-nginx-test
May 5, 2016
Merged

Add test to check if Nginx is serving requests#308
bors-servo merged 1 commit intoservo:masterfrom
aneeshusa:add-nginx-test

Conversation

@aneeshusa
Copy link
Contributor

urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.


This change is Reviewable

urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.

Enable the test on Travis as well.
@edunham
Copy link
Contributor

edunham commented May 5, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@edunham
Copy link
Contributor

edunham commented May 5, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 40cd1f7 has been approved by edunham

@bors-servo
Copy link
Contributor

⌛ Testing commit 40cd1f7 with merge d5c7994...

bors-servo pushed a commit that referenced this pull request May 5, 2016
Add test to check if Nginx is serving requests

urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/308)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants