Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check if Nginx is serving requests #308

Merged
merged 1 commit into from May 5, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Apr 7, 2016

urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.


This change is Reviewable

@aneeshusa aneeshusa force-pushed the aneeshusa:add-nginx-test branch from 19c3fd9 to 66bc4f5 Apr 7, 2016
urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.

Enable the test on Travis as well.
@aneeshusa aneeshusa force-pushed the aneeshusa:add-nginx-test branch from 66bc4f5 to 40cd1f7 Apr 7, 2016
@edunham
Copy link
Contributor

edunham commented May 5, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@edunham
Copy link
Contributor

edunham commented May 5, 2016

@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2016

📌 Commit 40cd1f7 has been approved by edunham

@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2016

Testing commit 40cd1f7 with merge d5c7994...

bors-servo added a commit that referenced this pull request May 5, 2016
Add test to check if Nginx is serving requests

urllib's error handling is not very helpful for this test, but I'm
using it in an effort to avoid extra dependencies. This only checks
if Nginx is alive and returning requests, not whether the HTTP status
codes indicate success. The reason for this is that the test pillars
we have in the repo are not valid, causing Buildbot and Homu to die
after starting, and thus Nginx returns 502 Bad Gateway errors when it
tries to reverse proxy requests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/308)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 40cd1f7 into servo:master May 5, 2016
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.