Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create error summary logs when running wptrunner-based tests #310

Merged
merged 1 commit into from Apr 20, 2016
Merged

Create error summary logs when running wptrunner-based tests #310

merged 1 commit into from Apr 20, 2016

Conversation

@jgraham
Copy link
Contributor

jgraham commented Apr 8, 2016

This change is Reviewable
@aneeshusa
Copy link
Member

aneeshusa commented Apr 9, 2016

You'll need to update the logfiles parameter as well for each ShellCommand so Buildbot knows to capture the new log files. Other than that, LGTM.
@aneeshusa aneeshusa mentioned this pull request Apr 10, 2016
Closed
@aneeshusa aneeshusa mentioned this pull request Apr 18, 2016
Merged
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2016

@jgraham ping
@jgraham
Create error summary logs when running wptrunner-based tests
Loading status checks…
5a7b867
@jgraham jgraham force-pushed the jgraham:wpt_errorsummary branch from dfa1bcd to 5a7b867 Apr 20, 2016
@jgraham
Copy link
Contributor Author

jgraham commented Apr 20, 2016

Done. Sorry missed this review in the first instance.
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

📌 Commit 5a7b867 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

⌛ Testing commit 5a7b867 with merge 3a50c3d...
bors-servo added a commit that referenced this pull request Apr 20, 2016
@bors-servo
Auto merge of #310 - jgraham:wpt_errorsummary, r=Ms2ger
Loading status checks…
3a50c3d 
Create error summary logs when running wptrunner-based tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/310)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 5a7b867 into servo:master Apr 20, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jgraham @aneeshusa @Ms2ger @bors-servo
You can’t perform that action at this time.