Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate on forbidden additions of unwrap #317

Merged
merged 1 commit into from Apr 14, 2016
Merged

Gate on forbidden additions of unwrap #317

merged 1 commit into from Apr 14, 2016

Conversation

@jdm
Copy link
Member

jdm commented Apr 14, 2016

Note: this shouldn't merge until servo/servo#10610 is merged, but then it should merge ASAP.


This change is Reviewable

@aneeshusa
Copy link
Member

aneeshusa commented Apr 14, 2016

@bors-servo r+ p=1

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2016

📌 Commit baf7ad6 has been approved by aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2016

Testing commit baf7ad6 with merge 96ee4c4...

bors-servo added a commit that referenced this pull request Apr 14, 2016
Gate on forbidden additions of unwrap

Note: this shouldn't merge until servo/servo#10610 is merged, but then it should merge ASAP.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/317)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2016

💔 Test failed - travis

@KiChjang
Copy link
Member

KiChjang commented Apr 14, 2016

System power off?

@aneeshusa
Copy link
Member

aneeshusa commented Apr 14, 2016

That's so weird, I have no idea what that could be. Hopefully it's intermittent.
@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2016

Testing commit baf7ad6 with merge b1d72a4...

bors-servo added a commit that referenced this pull request Apr 14, 2016
Gate on forbidden additions of unwrap

Note: this shouldn't merge until servo/servo#10610 is merged, but then it should merge ASAP.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/317)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

aneeshusa commented Apr 14, 2016

BTW, I need to run to a midterm now so someone else should finish landing this + deploying it on our Buildbots.

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit baf7ad6 into master Apr 14, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the jdm-patch-7 branch Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.