Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not use linux home path on macos #324
Merged
+2
−2
Conversation
|
@bors-servo r+ Deploying this for now to keep the repo in sync with prod. Buildbot is a bit weird in that we need to know details about the worker environment on the master - I'll have to think a little bit about how to do this cleanly. |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 16, 2016
Do not use linux home path on macos r? @aneeshusa How can I get `common.Darwin.servo_home`? Right now, in these lines we're getting the linux ones, which breaks the build. I tried using that string above, but it didn't work. I've deployed this version just to get the MacOS builders off the floor. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/324) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedApr 16, 2016
r? @aneeshusa
How can I get
common.Darwin.servo_home? Right now, in these lines we're getting the linux ones, which breaks the build. I tried using that string above, but it didn't work. I've deployed this version just to get the MacOS builders off the floor.This change is