Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix typo in Windows PATH #326
Merged
+1
−1
Conversation
|
Heh, I noticed this during #325 and fixed it there as well if you just want to wait for that. We can also merge this separately @bors-servo delegate+ |
|
|
|
@aneeshusa Thanks, I'd like to land it now as I'm trying to see if I can get the Windows builder online. I assume #325 will take some review :-) |
|
@bors-servo r=aneeshusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 18, 2016
Fix typo in Windows PATH r? @edunham @aneeshusa Should fix the error: ``` 'bash' is not recognized as an internal or external command, operable program or batch file. program finished with exit code 1 elapsedTime=0.109000 ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/326) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Apr 18, 2016
Fix typo in Windows PATH r? @edunham @aneeshusa Should fix the error: ``` 'bash' is not recognized as an internal or external command, operable program or batch file. program finished with exit code 1 elapsedTime=0.109000 ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/326) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedApr 18, 2016
r? @edunham @aneeshusa
Should fix the error:
This change is