Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure Buildbot master files are owned by servo #334
Merged
+9
−0
Conversation
If the Buildbot master is ever erroneously started as root, the permissions on a variety of files in the Buildbot master dir are clobbered and the Buildbot master process is unable to access them. Use a file.directory state to set ownership to servo:servo for the whole folder, so that a highstate will restore the correct permissions in case this happens.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 5, 2016
Ensure Buildbot master files are owned by servo If the Buildbot master is ever erroneously started as root, the permissions on a variety of files in the Buildbot master dir are clobbered and the Buildbot master process is unable to access them. Use a file.directory state to set ownership to servo:servo for the whole folder, so that a highstate will restore the correct permissions in case this happens. Fixes #332. r? @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/334) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 22, 2016
If the Buildbot master is ever erroneously started as root, the
permissions on a variety of files in the Buildbot master dir are
clobbered and the Buildbot master process is unable to access them.
Use a file.directory state to set ownership to servo:servo for the
whole folder, so that a highstate will restore the correct permissions
in case this happens.
Fixes #332. r? @edunham
This change is