Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure basic admin utilities are available #335

Merged
merged 2 commits into from Sep 12, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Apr 22, 2016

These are great tools that are even better together and make remote
administration an absolute delight. They make roaming between networks
seamless, which is something I do regularly.

Note that in order for mosh to work, we need to open some UDP ports; the full range of ports is 60001 to 60999, but we probably only need about 10 ports open (for 10 concurrent sessions) so ports 60001 to 60010. I personally am comfortable with mosh's security story (authentication via regular ssh), but let me know if you're not OK with opening these ports.


This change is Reviewable

admin-packages:
pkg.installed:
- pkgs:
- mosh

This comment has been minimized.

@Manishearth

Manishearth Apr 22, 2016

Member

Could we include sqlite3 (for debugging homu) and screen?

This comment has been minimized.

@aneeshusa

aneeshusa Apr 22, 2016

Author Member

I'll put sqlite3 just on the master machine.

I guess I can add screen, but tmux is just so nice... (plus, cowsay approved!):

 __________ 
< tmooooox >
 ---------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

(It's 4 AM here.)

This comment has been minimized.

@Manishearth

Manishearth Apr 22, 2016

Member

ahahaha

Yeah, I/Lars use screen.

This comment has been minimized.

@aneeshusa

aneeshusa Apr 22, 2016

Author Member

FYI, for now I'm just using the screen version that's pre-installed on OS X; it looks like there's a newer version available in Homebrew, but it's a little annoying to use from Salt. LMK if you need the newer version.

@aneeshusa aneeshusa force-pushed the aneeshusa:add-admin-utilities branch from fdd121f to cedeac6 Apr 22, 2016
@aneeshusa aneeshusa changed the title Ensure mosh and tmux are available Ensure basic admin utilities are available Apr 22, 2016
@aneeshusa aneeshusa force-pushed the aneeshusa:add-admin-utilities branch from cedeac6 to 747ac31 Aug 9, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Aug 9, 2016

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 12, 2016

@bors-servo r+

I've tried to resist my urge to add emacs24-nox to the list :-)

@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

📌 Commit 747ac31 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

Testing commit 747ac31 with merge 4bf2f2e...

bors-servo added a commit that referenced this pull request Aug 12, 2016
Ensure basic admin utilities are available

These are great tools that are even better together and make remote
administration an absolute delight. They make roaming between networks
seamless, which is something I do regularly.

Note that in order for mosh to work, we need to open some UDP ports; the full range of ports is 60001 to 60999, but we probably only need about 10 ports open (for 10 concurrent sessions) so ports 60001 to 60010. I personally am comfortable with mosh's security story (authentication via regular ssh), but let me know if you're not OK with opening these ports.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/335)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

💔 Test failed - status-travis

@aneeshusa
Copy link
Member Author

aneeshusa commented Aug 12, 2016

@larsbergstrom homu can't land anything until after landing #350 to fix pip

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 12, 2016

Aha, that's right - I forgot! I was so happy homu's finally landing again that I forgot it was broken for saltfs :-)

@edunham
Copy link
Contributor

edunham commented Aug 17, 2016

@bors-servo retry

if this fails, I'll edubors it :)

@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

Testing commit 747ac31 with merge 3b15ef2...

bors-servo added a commit that referenced this pull request Aug 17, 2016
Ensure basic admin utilities are available

These are great tools that are even better together and make remote
administration an absolute delight. They make roaming between networks
seamless, which is something I do regularly.

Note that in order for mosh to work, we need to open some UDP ports; the full range of ports is 60001 to 60999, but we probably only need about 10 ports open (for 10 concurrent sessions) so ports 60001 to 60010. I personally am comfortable with mosh's security story (authentication via regular ssh), but let me know if you're not OK with opening these ports.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/335)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

💔 Test failed - status-travis

@aneeshusa
Copy link
Member Author

aneeshusa commented Aug 18, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

Testing commit 747ac31 with merge 4e53957...

bors-servo added a commit that referenced this pull request Aug 18, 2016
Ensure basic admin utilities are available

These are great tools that are even better together and make remote
administration an absolute delight. They make roaming between networks
seamless, which is something I do regularly.

Note that in order for mosh to work, we need to open some UDP ports; the full range of ports is 60001 to 60999, but we probably only need about 10 ports open (for 10 concurrent sessions) so ports 60001 to 60010. I personally am comfortable with mosh's security story (authentication via regular ssh), but let me know if you're not OK with opening these ports.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/335)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

💔 Test failed - status-travis

aneeshusa added 2 commits Apr 22, 2016
These are great tools that are even better together and make remote
administration an absolute delight.
@aneeshusa aneeshusa force-pushed the aneeshusa:add-admin-utilities branch from 747ac31 to bf74aa6 Aug 19, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Aug 19, 2016

@bors-servo retry

  • Fixed mosh package name for Homebrew
@edunham
Copy link
Contributor

edunham commented Sep 7, 2016

@bors-servo retry

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 8, 2016

@bors-servo r+ clean

@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2016

📌 Commit 747ac31 has been approved by larsbergstrom

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 8, 2016

This is causing trouble for homu:

Calling start_build for sha 747ac315d32d4f2444cd109cd9b053d11e87e194 on PR: PullReqState:servo/saltfs#335(approved_by=larsbergstrom, priority=0, status=) with head sha bf74aa6f9bab26709c9913ba65ac35e9bed9da1b
Traceback (most recent call last):
  File "/home/servo/homu/_venv/bin/bottle.py", line 862, in _handle
    return route.call(**args)
  File "/home/servo/homu/_venv/bin/bottle.py", line 1732, in wrapper
    rv = callback(*a, **ka)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/server.py", line 396, in github
    g.queue_handler()
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/main.py", line 1050, in queue_handler
    return process_queue(states, repos, repo_cfgs, logger, buildbot_slots, db, git_cfg)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/main.py", line 727, in process_queue
    if start_build_or_rebuild(state, repo_cfgs, buildbot_slots, logger, db, git_cfg):
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/main.py", line 712, in start_build_or_rebuild
    return start_build(state, repo_cfgs, *args)
  File "/home/servo/homu/_venv/lib/python3.4/site-packages/homu/main.py", line 548, in start_build
    assert state.head_sha == state.get_repo().pull_request(state.num).head.sha
AssertionError

Closing & reopening.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 8, 2016

cc @edunham @Manishearth ^^^ is what was breaking homu

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 8, 2016

I have no idea why it wanted to start a build on 747ac31, which looks like it landed as part of another PR? Very curious...

@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 8, 2016

@larsbergstrom that commit is an older version of the 2nd (also most recent) commit in this PR. Maybe it didn't notice I pushed new versions of these commits?

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 8, 2016

Yeah, I suspect there's a VERY long-missed webhook message on homu's side that must have led to this, and possibly I could have fixed it by doing a 'sync' on saltfs instead of closing this? We can definitely give that a try, though I'd like to do so after we drain the servo/servo PR queue a little bit, since it backed up a bit while I left things broken :-)

@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 12, 2016

The Homu queue backlog has been cleared, so retrying this now.

@aneeshusa aneeshusa reopened this Sep 12, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 12, 2016

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2016

📌 Commit bf74aa6 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2016

Testing commit bf74aa6 with merge 08ed371...

bors-servo added a commit that referenced this pull request Sep 12, 2016
Ensure basic admin utilities are available

These are great tools that are even better together and make remote
administration an absolute delight. They make roaming between networks
seamless, which is something I do regularly.

Note that in order for mosh to work, we need to open some UDP ports; the full range of ports is 60001 to 60999, but we probably only need about 10 ports open (for 10 concurrent sessions) so ports 60001 to 60010. I personally am comfortable with mosh's security story (authentication via regular ssh), but let me know if you're not OK with opening these ports.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/335)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2016

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit bf74aa6 into servo:master Sep 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.