Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactored python function to create command line arguments #342
Conversation
| @@ -115,19 +115,17 @@ def make_step(self, command): | |||
| ]) | |||
|
|
|||
|
|
|||
| def make_cd_string(command): | |||
| return "cd /c/buildbot/slave/windows/build ; " + command | |||
| def make_cd_command(command): | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Apr 27, 2016
Member
This should be renamed to express the intent of the function, instead of what it is doing. Let's use make_win_command, since this function takes a regular command and makes it palatable to Windows.
| def make_cd_string(command): | ||
| return "cd /c/buildbot/slave/windows/build ; " + command | ||
| def make_cd_command(command): | ||
| return ["bash", "-l", "-c", "cd /c/buildbot/slave/windows/build ; " + command] |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Apr 27, 2016
Member
You'll need to split this onto two lines to fix the lint error (see the Travis logs for details). Also, the space between build and the semicolon can be removed.
I'd suggest using one line to construct the cd-prefixed string, and the second line to return the whole array.
|
This LGTM; please squash these commits together (you can use the commit message from the first commit). |
|
Thank you for the PR! |
|
|
Refactored python function to create command line arguments This commit is for issue #338 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/342) <!-- Reviewable:end -->
|
|
ashrwin commentedApr 27, 2016
•
edited by larsbergstrom
This commit is for issue #338
This change is