Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use steps.Test instead of steps.Compile #345

Merged
merged 1 commit into from Apr 28, 2016
Merged

Use steps.Test instead of steps.Compile #345

merged 1 commit into from Apr 28, 2016
+2 −2

Conversation

@CorcovadoMing
Copy link
Contributor

CorcovadoMing commented Apr 28, 2016 •
edited by larsbergstrom

fix #343

This change is Reviewable
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016

Please fix the lint error, looks good otherwise.
@CorcovadoMing
Copy link
Contributor Author

CorcovadoMing commented Apr 28, 2016

Sorry about that, I've fixed the lint error, please have a look
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016

Great, this just needs a squash.
@CorcovadoMing CorcovadoMing force-pushed the CorcovadoMing:patch-1 branch from 22ea7c9 to 6dd93ae Apr 28, 2016
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016 •
edited by larsbergstrom

Thanks for the PR!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

📌 Commit 6dd93ae has been approved by aneeshusa
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

📌 Commit 6dd93ae has been approved by aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

⌛ Testing commit 6dd93ae with merge 71e7463...
bors-servo added a commit that referenced this pull request Apr 28, 2016
@bors-servo
Auto merge of #345 - CorcovadoMing:patch-1, r=aneeshusa
Loading status checks…
71e7463 
Use steps.Test instead of steps.Compile

fix #343

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/345)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016

@bors-servo r-
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016

Can you update the commit message so it only has the first line and doesn't mention the pep8 fix?
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

☀️ Test successful - travis
@CorcovadoMing
use steps.Test instead of steps.Compile
Loading status checks…
15d4959
@CorcovadoMing CorcovadoMing force-pushed the CorcovadoMing:patch-1 branch from 6dd93ae to 15d4959 Apr 28, 2016
@CorcovadoMing
Copy link
Contributor Author

CorcovadoMing commented Apr 28, 2016

@aneeshusa Sure :)
@aneeshusa
Copy link
Member

aneeshusa commented Apr 28, 2016 •
edited by larsbergstrom

@CorcovadoMing Sorry about that, thanks for your patience :)

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

📌 Commit 15d4959 has been approved by aneeshusa
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

📌 Commit 15d4959 has been approved by aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

⌛ Testing commit 15d4959 with merge fd89f2b...
bors-servo added a commit that referenced this pull request Apr 28, 2016
@bors-servo
Auto merge of #345 - CorcovadoMing:patch-1, r=aneeshusa
Loading status checks…
fd89f2b 
Use steps.Test instead of steps.Compile

fix #343

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/345)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 28, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 15d4959 into servo:master Apr 28, 2016
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 1 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@irvin irvin mentioned this pull request Jan 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Use steps.Test instead of steps.Compile for './mach test-unit' on Windows
3 participants
@CorcovadoMing @aneeshusa @bors-servo
You can’t perform that action at this time.