Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate arm libs #347
Update arm libs #347
Conversation
|
This change wouldn't do anything; the list of packages you added |
|
I think trying to install the armhf and arm64 versions in this file should work, so that they get picked up by pkg-config. |
|
@aneeshusa You are right, my current approach won't solve the problem. :( It seems to me that this sysroot needs to be updated with the And we should do the same for the aarch64 rootfs as well. |
|
Yup, that sounds right! If you could please regenerate those two tarballs, I can work with @aneeshusa to upload them to s3 and use the versioned directory structures to roll it out and make them available. |
|
@larsbergstrom Could you point to some instructions on how those tarballs are generated, or better yet a repo with the scripts? I think it would be valuable to link to that information from this repo for reproducibility (and I'm curious about how it's done!). |
mmatyas
commented
May 2, 2016
•
|
Hi, I've regenerated the lib packages, you can find them here, with the |
|
Thanks @mmatyas! I filed #352 about scripting that process. @dati91, we'll need to wait for @larsbergstrom to upload the new tarballs to S3, but in the meantime can you update this PR to point our ARM builders to the new tarballs? Should be as easy as updating the version and sha512 fields in this file. |
|
I've made them available at the |
|
@larsbergstrom I checked S3 and you put the tarballs in the wrong place - can you please upload the new tarballs to |
| @@ -36,7 +36,7 @@ arm-dependencies: | |||
| libs-{{ target.name }}: | |||
| archive.extracted: | |||
| - name: {{ common.servo_home }}/rootfs-trusty-{{ target.name }}/{{ target.version }} | |||
| - source: https://servo-rust.s3.amazonaws.com/ARM/{{ target.download_name }}/{{ target.version }}/{{ target.download_name }}-{{ target.version }}.tgz | |||
| - source: https://servo-rust.s3.amazonaws.com/ARM/{{ target.version }}/{{ target.download_name }}.tgz | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
May 3, 2016
Member
Please keep this URL the way it is - it's more verbose but it's more robust:
- Can update arm32 and arm64 independently
- If you download a bunch of tarballs from S3 , they'll have different names and will happily coexist on your filesystem
This comment has been minimized.
This comment has been minimized.
dati91
May 3, 2016
Author
Contributor
But currently the v2 lib can only be found on that specific url (and the others as well).
This comment has been minimized.
This comment has been minimized.
larsbergstrom
May 3, 2016
Contributor
I think I put them there now:
[larsberg@lbergstrom ~]$ s3cmd cp s3://servo-rust/ARM/v2/armhf* s3://servo-rust/ARM/armhf-trusty-libs/v2/
remote copy: 's3://servo-rust/ARM/v2/armhf-trusty-libs.tgz' -> 's3://servo-rust/ARM/armhf-trusty-libs/v2/armhf-trusty-libs.tgz'
[larsberg@lbergstrom ~]$ s3cmd cp s3://servo-rust/ARM/v2/arm64* s3://servo-rust/ARM/arm64-trusty-libs/v2/
remote copy: 's3://servo-rust/ARM/v2/arm64-trusty-libs.tgz' -> 's3://servo-rust/ARM/arm64-trusty-libs/v2/arm64-trusty-libs.tgz'
[larsberg@lbergstrom ~]$
This comment has been minimized.
This comment has been minimized.
dati91
May 3, 2016
Author
Contributor
if you want the original link, you still missing the *-{{target.version}}.tgz from the end
This comment has been minimized.
This comment has been minimized.
larsbergstrom
May 3, 2016
Contributor
Ugh, I'll try a third time later tonight.
On May 3, 2016, at 4:58 PM, Attila Dusnoki notifications@github.com wrote:
In servo-build-dependencies/arm.sls
#347 (comment):
@@ -36,7 +36,7 @@ arm-dependencies:
libs-{{ target.name }}:
archive.extracted:
- name: {{ common.servo_home }}/rootfs-trusty-{{ target.name }}/{{ target.version }}
- source: https://servo-rust.s3.amazonaws.com/ARM/{{ target.download_name }}/{{ target.version }}/{{ target.download_name }}-{{ target.version }}.tgz
- source: https://servo-rust.s3.amazonaws.com/ARM/{{ target.version }}/{{ target.download_name }}.tgz
if you want the original link, you still missing the
*-{{target.version}}.tgz from the end
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/servo/saltfs/pull/347/files/5303ab87b1e2bcb61ae42f3e27329ee677dd39d3#r61963556
|
The tarballs should be uploaded to the right place now, but I'd like to check this out in Vagrant before approving to make sure the upgrade will work smoothly. |
|
Everything looked good in Vagrant, thanks for the PR. @bors-servo r+ |
|
|
Update arm libs This should fix the servo/servo#10632 arm build errors. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/347) <!-- Reviewable:end -->
|
|
dati91 commentedApr 29, 2016
•
edited by larsbergstrom
This should fix the servo/servo#10632 arm build errors.
This change is