Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run etc/ci/chaos_monkey_test.py, non-gating #360

Merged
merged 1 commit into from Aug 30, 2017
Merged

Run etc/ci/chaos_monkey_test.py, non-gating #360

merged 1 commit into from Aug 30, 2017
+5 −2

Conversation

@edunham
Copy link
Contributor

edunham commented May 5, 2016 •
edited by larsbergstrom

As requested in servo/servo#10927

r? @larsbergstrom

This change is Reviewable
@aneeshusa
Copy link
Member

aneeshusa commented May 5, 2016

cc @asajeffrey
I think we wanted to try running these on a nightly builder first before gating, since this test has the potential to be very intermittent.
@asajeffrey
Copy link
Member

asajeffrey commented May 6, 2016

Indeed, it would be nice to run this without gating, just so we can see if we're getting new intermittents. If that's not doable, we could gate as long as we can ungate in a hurry if necessary! This may make Monday a better day to start gating than a Friday when I'm travelling :)
@edunham edunham force-pushed the edunham:gate-on-monkey branch from 339d9d9 to 4b63f0d May 11, 2016
@edunham edunham changed the title Gate on etc/ci/chaos_monkey_test.py Run etc/ci/chaos_monkey_test.py, non-gating May 11, 2016
@edunham
Copy link
Contributor Author

edunham commented May 11, 2016 •
edited

@aneeshusa Current changes create a new builder, linux-nogate, which will run chaos_monkey_test whenever the other Linux builders are triggered. Build results will not be considered by Homu, because we aren't telling Homu that the builder exists.
buildbot/master/files/config/steps.yml Outdated
@@ -34,6 +34,9 @@ linux-dev:
- bash ./etc/ci/manifest_changed.sh
- bash ./etc/ci/check_no_unwrap.sh

linux-nogate:
- bash ./etc/ci/chaos_monkey_test.sh

This comment has been minimized.

Sign in to view
@aneeshusa

aneeshusa May 11, 2016

Member

This is actually a python script.

This comment has been minimized.

Sign in to view
@aneeshusa

aneeshusa May 11, 2016

Member

Also, I think we need to ./mach build --release beforehand.
@edunham edunham force-pushed the edunham:gate-on-monkey branch from 4b63f0d to e45c8cb May 11, 2016
@edunham
Copy link
Contributor Author

edunham commented May 11, 2016

failure on master is because

    DynamicServoBuilder("linux-nogate", LINUX_SLAVES, envs.build_linux_headless),

is 81 characters.

@aneeshusa which workaround for this lint failure would you consider least objectionable -- renaming linux-nogate to something shorter, renaming envs.build_linux_headless to something shorter, breaking the line, changing the lint...
@aneeshusa
Copy link
Member

aneeshusa commented May 11, 2016

Get rid of envs.build_linux_headless. servo/servo#8641 got rid of the SERVO_HEADLESS environment variable (headless is a runtime option instead of a compile time option), so we can just use envs.build_linux instead.
@aneeshusa
Copy link
Member

aneeshusa commented May 11, 2016

r=me after switching the order of the commits (I think separate commits is better than squashing here).
@aneeshusa
Copy link
Member

aneeshusa commented May 12, 2016

Also, if you have enough space on the line, it would be nice to rename linux-nogate to linux-rel-nogate.
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2016

☔ The latest upstream changes (presumably #373) made this pull request unmergeable. Please resolve the merge conflicts.
@aneeshusa
Copy link
Member

aneeshusa commented Jun 29, 2016

Ping on finishing this - could prevent issues like servo/servo#11926.
@edunham edunham force-pushed the edunham:gate-on-monkey branch from f6f9ee4 to 2695843 Jul 12, 2016
buildbot/master/files/config/master.cfg Outdated
@@ -160,6 +162,9 @@ class DynamicServoYAMLBuilder(util.BuilderConfig):
)

c['builders'] = [
DynamicServoBuilder("linux-dev", LINUX_SLAVES, envs.build_linux),

This comment has been minimized.

Sign in to view
@aneeshusa

aneeshusa Aug 9, 2016

Member

Don't duplicate linux-dev and linux-rel.
buildbot/master/files/config/master.cfg Outdated
@@ -160,6 +162,9 @@ class DynamicServoYAMLBuilder(util.BuilderConfig):
)

c['builders'] = [
DynamicServoBuilder("linux-dev", LINUX_SLAVES, envs.build_linux),
DynamicServoBuilder("linux-nogate", LINUX_SLAVES, envs.build_linux),

This comment has been minimized.

Sign in to view
@aneeshusa

aneeshusa Aug 9, 2016

Member

Ideally, this is linux-rel-nogate if it fits on one line.
@aneeshusa aneeshusa self-assigned this Aug 9, 2016
@aneeshusa
Copy link
Member

aneeshusa commented Aug 9, 2016

LGTM aside from the nits, please rebase + squash.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2016

☔ The latest upstream changes (presumably #494) made this pull request unmergeable. Please resolve the merge conflicts.
@edunham
Alphebetize builder lists and add linux-rel-nogate
Loading status checks…
2fbeef3
@edunham edunham force-pushed the edunham:gate-on-monkey branch from 2695843 to 2fbeef3 Jul 14, 2017
@edunham
Copy link
Contributor Author

edunham commented Jul 14, 2017

@aneeshusa Updated this one to account for the refactors since I accidentally forgot it existed.
@edunham edunham mentioned this pull request Jul 14, 2017
Merged
bors-servo added a commit to servo/servo that referenced this pull request Jul 14, 2017
@bors-servo
Auto merge of #17734 - edunham:nogate, r=jdm
Loading status checks…
8e14d93 
Run chaos_monkey_test on the non-gating builder

re #10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17734)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 15, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
3e7eb9e 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1ac0eb59d5103e203594f68b719cc34e530bc4d3
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request Jul 17, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
009a595 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Jul 17, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
32cc938 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a
Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Jul 17, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
947cae9 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a
staktrace pushed a commit to staktrace/gecko-dev that referenced this pull request Jul 17, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
fb486f4 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a
leobalter pushed a commit to leobalter/gecko-dev that referenced this pull request Jul 20, 2017
@edunham
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
7891f93 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a
@aneeshusa
Copy link
Member

aneeshusa commented Aug 30, 2017

Thanks @edunham for getting back to this!
@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

📌 Commit 2fbeef3 has been approved by aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

⌛ Testing commit 2fbeef3 with merge d49a761...
bors-servo added a commit that referenced this pull request Aug 30, 2017
@bors-servo
Auto merge of #360 - edunham:gate-on-monkey, r=aneeshusa
Loading status checks…
d49a761 
Run etc/ci/chaos_monkey_test.py, non-gating

As requested in servo/servo#10927

r? @larsbergstrom

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/360)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 30, 2017

☀️ Test successful - status-travis
Approved by: aneeshusa
Pushing d49a761 to master...
@bors-servo bors-servo merged commit 2fbeef3 into servo:master Aug 30, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
527c1f9 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a

UltraBlame original commit: 307eb68974d8ce9567bcbf9f7110bc98e4f8fb18
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
e1810bd 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a

UltraBlame original commit: 307eb68974d8ce9567bcbf9f7110bc98e4f8fb18
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
@marco-c
servo: Merge #17734 - Run chaos_monkey_test on the non-gating builder…
cdcb05a 
… (from edunham:nogate); r=jdm

re servo/servo#10927, servo/saltfs#360

the old salt pr became a salt pr + a servo pr due to the buildbot steps living over here now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e14d936022b863061ffc42cccc86922be03951a

UltraBlame original commit: 307eb68974d8ce9567bcbf9f7110bc98e4f8fb18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aneeshusa aneeshusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@edunham @aneeshusa @asajeffrey @bors-servo @highfive
You can’t perform that action at this time.