Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable Homebrew Analytics #361
Merged
Conversation
This is not the most robust of solutions, but will do the job. A better solution would be a custom Salt state, backed by a custom Salt module, that uses the `brew analytics` command to stay decoupled from implementation details. Instead, directly change the git config settings of the local Homebrew repo to disable analytics.
|
In terms of testing, we'd need to |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 12, 2016
Disable Homebrew Analytics This is not the most robust of solutions, but will do the job. A better solution would be a custom Salt state, backed by a custom Salt module, that uses the `brew analytics` command to stay decoupled from implementation details. Instead, directly change the git config settings of the local Homebrew repo to disable analytics. Fixes #340. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/361) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMay 5, 2016
•
edited by larsbergstrom
This is not the most robust of solutions, but will do the job.
A better solution would be a custom Salt state, backed by a custom
Salt module, that uses the
brew analyticscommand to stay decoupledfrom implementation details.
Instead, directly change the git config settings of the local
Homebrew repo to disable analytics.
Fixes #340.
This change is