Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd caching of Cargo and Rust bits to Windows #362
Merged
Conversation
|
I put all of the environment variables in alphabetical order, so please move |
0e0f3e5
to
955790e
|
@bors-servo r=aneeshusa |
|
|
bors-servo
added a commit
that referenced
this pull request
May 6, 2016
Add caching of Cargo and Rust bits to Windows r? @edunham @aneeshusa Fixes #358 I decided to use the msys home dir instead of `%APPDATA%` for consistency with the other unix builds, but could be convinced otherwise if we get to a point where Servo is not building inside of the msys/mingw environment. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/362) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedMay 6, 2016
•
edited
r? @edunham @aneeshusa
Fixes #358
I decided to use the msys home dir instead of
%APPDATA%for consistency with the other unix builds, but could be convinced otherwise if we get to a point where Servo is not building inside of the msys/mingw environment.This change is