Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching of Cargo and Rust bits to Windows #362

Merged
merged 1 commit into from May 6, 2016

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 6, 2016

r? @edunham @aneeshusa

Fixes #358

I decided to use the msys home dir instead of %APPDATA% for consistency with the other unix builds, but could be convinced otherwise if we get to a point where Servo is not building inside of the msys/mingw environment.


This change is Reviewable

@aneeshusa
Copy link
Member

aneeshusa commented May 6, 2016

I put all of the environment variables in alphabetical order, so please move SERVO_CACHE_DIR to be after PATH and then r=me.

@larsbergstrom larsbergstrom force-pushed the larsbergstrom:windows_caching branch from 0e0f3e5 to 955790e May 6, 2016
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented May 6, 2016

@bors-servo r=aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

📌 Commit 955790e has been approved by aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

Testing commit 955790e with merge 99a690f...

bors-servo added a commit that referenced this pull request May 6, 2016
Add caching of Cargo and Rust bits to Windows

r? @edunham @aneeshusa

Fixes #358

I decided to use the msys home dir instead of `%APPDATA%` for consistency with the other unix builds, but could be convinced otherwise if we get to a point where Servo is not building inside of the msys/mingw environment.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/362)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 955790e into servo:master May 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.