Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed IPs to Hostnames where possible, and removed host.present tes… #369

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Removed use of IPs for hosts. Made /etc/hosts a managed file.

  • Loading branch information
setupminimal committed Jun 5, 2016
commit 672cbe3f8c9194e55f2de38d97238d5a8c855056
@@ -0,0 +1,3 @@
127.0.0.1 localhost
::1 localhost
255.255.255.255 broadcasthost
@@ -40,16 +40,21 @@ servo:
- shell: /bin/bash
- home: {{ common.servo_home }}
{% for hostname, ip in common.hosts.items() %}
host-{{ hostname }}:
host.present:
- name: {{ hostname }}
- ip: {{ ip }}
{% endfor %}
{% for ssh_user in common.ssh_users %}
sshkey-{{ ssh_user }}:
ssh_auth.present:
- user: root
- source: salt://{{ tpldir }}/ssh/{{ ssh_user }}.pub
{% endfor %}
hosts-file:

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 8, 2016

Member

This can be /etc/hosts instead, and then the name parameter is unnecessary down below.

file.managed:
- name: /etc/hosts
- user: root
- mode: 644
{% if grains['os'] == 'MacOS' %}
- group: wheel
{% elif grains['os'] == 'Ubuntu' %}
- group: root"

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 8, 2016

Member

There's a trailing " here.

{% endif %}
- location: /common/files/hosts
@@ -2,15 +2,6 @@
set common = salt['grains.filter_by']({
'defaults': {
'servo_home': '/home/servo',
'hosts': {
'servo-master': '96.126.125.232',
'servo-linux1': '66.228.48.56',
'servo-linux2': '173.255.201.95',
'servo-linux3': '45.79.167.177',
'servo-linux-android1': '72.14.176.110',
'servo-mac1': '208.52.161.130',
'servo-mac3': '63.135.170.19',
},
'ssh_users': [
'ajeffrey',
'aneeshusa',
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.