Commits on May 16, 2016

1. Use Nginx to make Buildbot logs available via CORS …

   Buildbot itself (neither the current version eight nor the upcoming
   verison nine) does not seem to have built-in CORS support, so use Nginx
   to supply CORS headers while reverse proxying.
   
   This is only needed to download log files, so start with a very
   conservative set of CORS headers. In particular:
     - Only support basic CORS requests (those that don't require preflight
       requests via OPTIONS). This means supporting only GET requests.
     - Do not allow sending cookies or exposing any headers.
   In return, whitelist all domains for CORS, and send the Allow-Origin
   header unconditionally, as the actual value of the Origin header does
   not matter.
   
   Because we are using proxy_pass to reverse proxy Buildbot, we need to
   tell Nginx to always add the CORS headers, instead of only adding them
   for successful responses. (I.e. add CORS headers even for 404s and other
   erroneous status codes). This features is not available in the Nginx
   packaged for Ubuntu Trusty, so replace it with a newer Nginx from
   upstream Nginx's respositories.
   
   Because Debian/Ubuntu modify the default configuration for Nginx, use
   Salt to ensure that the installed nginx.conf properly looks into the
   sites-enabled directory (which is a Debian-ism) and that the default
   handler in /etc/nginx/conf.d/ is purged.
   
   In order to only support CORS on GET requests, use the 'if' directive.
   However, because Nginx's if is evil,
   (https://www.nginx.com/resources/wiki/start/topics/depth/ifisevil/)
   add a bunch of tests to ensure that the configuration is working.
   
   Also, update the Nginx states to follow Salt best practices.

   

   aneeshusa committed May 16, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 5d93b54
   • Browse repository at this point

   Copy the full SHA

   5d93b54 View commit details

   Browse the repository at this point in the history