Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure specific Android SDK platform version is installed #383
Conversation
Update the creates parameter to the cmd.run state which installs the Android SDK to check for both the platform tools and the specific version of the platform we are using (currently, android-18). This makes sure that the SDK will reinstalled on future Salt runs if either directory is missing, instead of just checking for the platform tools. Also, extract the Android platform into a Jinja variable. Note that this feature of Salt is not documented, hence why I didn't do this originally - I thought it didn't exist. I only discovered it when I went into the Salt codebase to implement it myself.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 25, 2016
…y, r=larsbergstrom Ensure specific Android SDK platform version is installed Update the creates parameter to the cmd.run state which installs the Android SDK to check for both the platform tools and the specific version of the platform we are using (currently, android-18). This makes sure that the SDK will reinstalled on future Salt runs if either directory is missing, instead of just checking for the platform tools. Also, extract the Android platform into a Jinja variable. Note that this feature of Salt is not documented, hence why I didn't do this originally - I thought it didn't exist. I only discovered it when I went into the Salt codebase to implement it myself. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/383) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMay 25, 2016
•
edited by larsbergstrom
Update the creates parameter to the cmd.run state which installs the
Android SDK to check for both the platform tools and the specific
version of the platform we are using (currently, android-18). This
makes sure that the SDK will reinstalled on future Salt runs if either
directory is missing, instead of just checking for the platform tools.
Also, extract the Android platform into a Jinja variable.
Note that this feature of Salt is not documented, hence why I didn't
do this originally - I thought it didn't exist. I only discovered it
when I went into the Salt codebase to implement it myself.
This change is