Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildbot GitHub status integration #387

Merged

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented May 26, 2016

Buildbot 0.8.12 has a GitHub status integration; it would be better to
use that directly instead of making Homu act as a middleman. Note that
this commit does not change the Homu configuration, but only adds a
GitHub status integration for Buildbot.

Note that this requires a new secret value in the Pillar - a token
that Buildbot can use to access the GitHub status API.

See http://docs.buildbot.net/current/manual/cfg-statustargets.html#githubstatus
for more details on the integration.


This change is Reviewable

@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

The latest upstream changes (presumably #410) made this pull request unmergeable. Please resolve the merge conflicts.

@edunham
Copy link
Contributor

edunham commented Jul 11, 2016

This looks like it might report more builds than Homu is doing, which would be an improvement.

@bors-servo r+

Sorry for the delay in review, but this looks good to go after fixing the merge conflict.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

📌 Commit 3964299 has been approved by edunham

@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

🔒 Merge conflict

Buildbot 0.8.12 has a GitHub status integration; it would be better to
use that directly instead of making Homu act as a middleman. Note that
this commit does not change the Homu configuration, but only adds a
GitHub status integration for Buildbot.

Note that this requires a new secret value in the Pillar - a token
that Buildbot can use to access the GitHub status API.

See http://docs.buildbot.net/current/manual/cfg-statustargets.html#githubstatus
for more details on the integration.
@aneeshusa aneeshusa force-pushed the aneeshusa:use-buildbot-github-status-integration branch from 3964299 to 554165b Jul 12, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Jul 12, 2016

Rebased. @bors-servo r=edunham

Fun fact: I completely forgot I had already removed Buildbot categories as the first commit in this PR and opened #412 recently as an E-easy, hence only one commit left on this PR.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

📌 Commit 554165b has been approved by edunham

@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

Testing commit 554165b with merge 8b2cc91...

bors-servo added a commit that referenced this pull request Jul 12, 2016
…, r=edunham

Use buildbot GitHub status integration

Buildbot 0.8.12 has a GitHub status integration; it would be better to
use that directly instead of making Homu act as a middleman. Note that
this commit does not change the Homu configuration, but only adds a
GitHub status integration for Buildbot.

Note that this requires a new secret value in the Pillar - a token
that Buildbot can use to access the GitHub status API.

See http://docs.buildbot.net/current/manual/cfg-statustargets.html#githubstatus
for more details on the integration.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/387)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

📌 Commit 554165b has been approved by edunham

@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 554165b into servo:master Jul 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.