Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Android build tools for cross compilation #388

Merged
merged 1 commit into from Jun 20, 2016

Conversation

aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented May 27, 2016

The Android build tools are required for building an APK.
They are versioned separately from the SDK and do not have a version
requirement - best practice is to use the latest (stable) release.

After servo/servo#11406 landed, I forced an android-nightly build, which now gets further but still fails. The new failure is http://build.servo.org/builders/android-nightly/builds/60/steps/shell_1/logs/stdio, so install the build tools to fix this.

Edit: relevant error for posterity:

BUILD FAILED
/home/servo/android/sdk/current/tools/ant/build.xml:483: SDK does not have any Build Tools installed.

Another step for servo/servo#10339.

I think this would benefit from #374 - I had a lot of errors trying to get the android tool to install the build tools where blowing away the directory fixed it. I think the --all parameter should take care of it, but I'd like to be more sure.


This change is Reviewable

The Android build tools are required for building an APK.
They are versioned separately from the SDK and do not have a version
requirement - best practice is to use the latest (stable) release.
@aneeshusa
Copy link
Contributor Author

May also help with servo/servo#8464, since we can depend on a more stable version of the build tools. (We can just require the same build tools version for packagers that we run on the CI, at least for now.)

@edunham
Copy link
Contributor

edunham commented Jun 20, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 97391de has been approved by edunham

@bors-servo
Copy link
Contributor

⌛ Testing commit 97391de with merge 3db85a1...

bors-servo pushed a commit that referenced this pull request Jun 20, 2016
Install Android build tools for cross compilation

The Android build tools are required for building an APK.
They are versioned separately from the SDK and do not have a version
requirement - best practice is to use the latest (stable) release.

After servo/servo#11406 landed, I forced an android-nightly build, which now gets further but still fails. The new failure is http://build.servo.org/builders/android-nightly/builds/60/steps/shell_1/logs/stdio, so install the build tools to fix this.

Edit: relevant error for posterity:
```
BUILD FAILED
/home/servo/android/sdk/current/tools/ant/build.xml:483: SDK does not have any Build Tools installed.
```

Another step for servo/servo#10339.

I think this would benefit from #374 - I had a lot of errors trying to get the android tool to install the build tools where blowing away the directory fixed it. I think the --all parameter should take care of it, but I'd like to be more sure.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/388)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 97391de into servo:master Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants