Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprioritize builds that are in the "try" branch. #4
Conversation
modified: buildbot/master/master.cfg
This comment has been minimized.
This comment has been minimized.
larsbergstrom
commented on 3d1c522
Dec 11, 2014
|
This looks like a great start! Do you know if there's a way to disable setting the GitHub status for builds run on the try branch? The scenario I'm worried about is:
|
This comment has been minimized.
This comment has been minimized.
|
There isn't. I've been looking into it for a few days now and there doesn't seem to be a way to have Buildbot disable status updates for a build. I asked on the IRC channel of Buildbot to make sure. My solution to this was to create a wrapper around the I think if I can filter it out before it gets to the status service, then we'll be in business. Ideally the only changes in the source would be to wrap s['status'].append(FilteredStatus(
GitHubStatus(
token="",
repoOwner="",
repoName=""
),
change_filter = change_filter_fn
))So far it's... a work in progress. I figured I do it that way just in case an IRC or a different kind of status reporter is added. The only downside to this is that you'll have to use a custom build for Buildbot, which isn't too bad. |
This comment has been minimized.
This comment has been minimized.
|
Hm, new discoveries show that it would probably be easier to do this another way. The problem I'm running into is that |
|
Merging this to land @bheesham's changes and build on them. |
Deprioritize builds that are in the "try" branch.
larsbergstrom commentedDec 12, 2014