Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html5ever repo support to homu. #40

Merged
merged 1 commit into from Jun 9, 2015
Merged

Conversation

@metajack
Copy link
Contributor

metajack commented Jun 9, 2015

To enable repos you have to:

  1. Add them in the homu/cfg.toml by adding to the list as ('$owner', '$repo')
  2. Add a webhook for http://build.servo.org:54856/github to the repo webhooks for push,pull request, and issue comments with the secret key (see private data pillar for the key)
  3. Add a webhook in .travis.yml in the repo pointing at http://build.servo.org:54856/travis

Additionally you may need to reset the travis token and associated user in the travis service in the github admin panel for the repo. (use bors-servo as the user).

@metajack
Copy link
Contributor Author

metajack commented Jun 9, 2015

@edunham
Copy link
Contributor

edunham commented Jun 9, 2015

If you've already set the value for reviewers in the pillar, I think it should be good. I often trust syntax highlighting to point out errors in files like this, but github's clearly unaware that it's actually jinja-templated. html5ever already has the hook that you described (https://github.com/servo/html5ever/blob/master/.travis.yml). Will you do the repo webhooks, or would you like me to?

@metajack
Copy link
Contributor Author

metajack commented Jun 9, 2015

There's no reviewers value in the pillar. The value is initially set here in the template.
I already did the mentioned steps for html5ever, but we'll have to repeat those steps for the other repos we enable. i wasn't sure where to put such documentation, so I figured I'd at least get it into the PR description.

Suggestions on where docs should go?

@edunham
Copy link
Contributor

edunham commented Jun 9, 2015

How does https://github.com/servo/saltfs/wiki/Adding-a-repo-to-Homu look for now, and we can replace it with a link to the new location if we find a better place?

I'll also update them if the process doesn't work right for this PR.

@metajack
Copy link
Contributor Author

metajack commented Jun 9, 2015

Excellent!

@metajack
Copy link
Contributor Author

metajack commented Jun 9, 2015

Any other concerns, or is this ready to merge and deploy?

@edunham
Copy link
Contributor

edunham commented Jun 9, 2015

If there are any syntax errors, I'm not seeing them. Let's merge and deploy 👍

metajack added a commit that referenced this pull request Jun 9, 2015
Add html5ever repo support to homu.
@metajack metajack merged commit 86102db into servo:master Jun 9, 2015
@metajack metajack deleted the metajack:more-homu-repos branch Jun 9, 2015
Manishearth pushed a commit that referenced this pull request Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.