Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplaced hard coded color with RED constant from utils.py #400
Conversation
|
Thanks for the PR, and welcome to Servo! One quick nit: can you put Looks good otherwise. |
|
Thanks for the quick reply! I've reordered the import and pushed a new commit. |
|
Great, please squash these commits together. |
|
OK, commit squashed. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 18, 2016
Replaced hard coded color with RED constant from utils.py This is to fix: #378 #381 had been closed due to inactivity so I picked this task to start contributing to servo. Hopefully this resolves the outstanding comments from 381. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/400) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
leahnp commentedJun 18, 2016
•
edited by larsbergstrom
This is to fix: #378
#381 had been closed due to inactivity so I picked this task to start contributing to servo. Hopefully this resolves the outstanding comments from 381.
This change is