Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Update SSH key to RSA now that DSA no longer works#404

Merged
bors-servo merged 1 commit intoservo:masterfrom
metajack:ssh-jack-rsa
Jun 23, 2016
Merged

Update SSH key to RSA now that DSA no longer works#404
bors-servo merged 1 commit intoservo:masterfrom
metajack:ssh-jack-rsa

Conversation

@metajack
Copy link
Contributor

@metajack metajack commented Jun 23, 2016

This change is Reviewable

@edunham
Copy link
Contributor

edunham commented Jun 23, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e874fc8 has been approved by edunham

@bors-servo
Copy link
Contributor

⌛ Testing commit e874fc8 with merge e89bfa8...

bors-servo pushed a commit that referenced this pull request Jun 23, 2016
Update SSH key to RSA now that DSA no longer works

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit e874fc8 into servo:master Jun 23, 2016
@metajack metajack deleted the ssh-jack-rsa branch June 23, 2016 20:39
@aneeshusa
Copy link
Contributor

DSA keys are certainly weak, so I'm glad to see them go. However, while we are in the process of standardizing and securing our OpenSSH configuration, I personally would like to see everyone move to Ed25519 keys instead of RSA keys. Everyone will need to change how they connect anyways for #253, so I think this would be a nice opportunity to also bump our key strength and take advantage of ECC. Thoughts?

(Note that Ed25519 keys won't work just yet, they will need some Salt work.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants