Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate SSH key to RSA now that DSA no longer works #404
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 23, 2016
Update SSH key to RSA now that DSA no longer works <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/404) <!-- Reviewable:end -->
|
|
|
DSA keys are certainly weak, so I'm glad to see them go. However, while we are in the process of standardizing and securing our OpenSSH configuration, I personally would like to see everyone move to Ed25519 keys instead of RSA keys. Everyone will need to change how they connect anyways for #253, so I think this would be a nice opportunity to also bump our key strength and take advantage of ECC. Thoughts? (Note that Ed25519 keys won't work just yet, they will need some Salt work.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJun 23, 2016
•
edited by larsbergstrom
This change is