Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd linux and osx nightly builds #410
Merged
Conversation
|
I was going to submit this as a PR to #409 but the changes didn't end up having that much in common. |
|
this looks good to me after we land servo/servo#11943 |
aneeshusa
force-pushed the
aneeshusa:add-linux-and-osx-nightly-builds
branch
from
d84f850
to
0687891
|
Deployment note: This requires pillar changes to work. |
aneeshusa
force-pushed the
aneeshusa:add-linux-and-osx-nightly-builds
branch
from
0687891
to
0126661
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
…rsbergstrom Add linux and osx nightly builds Alternative to #409 that is more secure IMO. Requires servo/servo#11943. cc @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/410) <!-- Reviewable:end -->
aneeshusa
force-pushed the
aneeshusa:add-linux-and-osx-nightly-builds
branch
from
0126661
to
3a828e6
|
Got Vagrant up so I can test this, hold off for one minute while I get the tests passing since Travis is a bit slow right now. |
Uses new etc/ci/upload_nightly.sh script. Passes credentials more securely via environment variables.
aneeshusa
force-pushed the
aneeshusa:add-linux-and-osx-nightly-builds
branch
from
3a828e6
to
f9f1230
|
@bors-servo r=larsbergstrom servo/servo#11943 needs to be merged before deploying this. |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
…rsbergstrom Add linux and osx nightly builds Alternative to #409 that is more secure IMO. Requires servo/servo#11943. cc @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/410) <!-- Reviewable:end -->
|
|
This was referenced Jun 30, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJun 30, 2016
•
edited by larsbergstrom
Alternative to #409 that is more secure IMO.
Requires servo/servo#11943.
cc @larsbergstrom @edunham
This change is