Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd windows nightly build #411
Merged
Conversation
The last thing to alphabetize is the steps.yml file.
This should be very useful for testing before release.
Also add a single environment to use for uploading nightlies, thus restricting the environment variables passed to the upload script and making it easier to add other uploading environments. Also fix the make_step functions to actually use the configured environment instead of just using self.environment.
Closed
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2016
…trom Add windows nightly build Also has some important fixes for the other nightly builders. cc @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/411) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJun 30, 2016
•
edited by larsbergstrom
Also has some important fixes for the other nightly builders.
cc @larsbergstrom @edunham
This change is