Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved Buildbot Categories #419
Merged
Conversation
|
Thanks for the PR! The code changes look good but I have a few comments about the commit message:
|
this-jacob
force-pushed the
this-jacob:remove_buildbot_categories
branch
from
dc0f6ce
to
bc00b2d
|
@aneeshusa Do these changes work? |
this-jacob
force-pushed the
this-jacob:remove_buildbot_categories
branch
from
bc00b2d
to
4c4c19f
|
Just a few spelling/grammar nits:
|
Since the categories parameter was deprecated in Buildbot version 0.8.12, the version currently in use, remove it.
this-jacob
force-pushed the
this-jacob:remove_buildbot_categories
branch
from
4c4c19f
to
987b364
|
@aneeshusa okay, I fixed those spelling issues |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 1, 2016
Removed Buildbot Categories Addresses Issue: #412 Removed unused categories on the builders. Additionally the `categories` parameter was deprecated in Buildbot 0.8.12 (the version currently in use) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/419) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
this-jacob commentedJun 30, 2016
•
edited
Addresses Issue: #412
Removed unused categories on the builders.
Additionally the
categoriesparameter was deprecated in Buildbot 0.8.12 (the version currently in use)This change is