Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPre-split cat step.yml command #424
Merged
+1
−2
Conversation
We are passing the command as an array, so we need to pre-split the command into separate words.
aneeshusa
force-pushed the
aneeshusa:pre-split-cat-steps-command
branch
from
86d2a92
to
af5ab0a
|
r? @edunham or @larsbergstrom |
|
@bors-servo r+ Well, if it didn't break prod ;) |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 13, 2016
Pre-split cat step.yml command We are passing the command as an array, so we need to pre-split the command into separate words. Naughtily tested in prod. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/424) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJul 3, 2016
•
edited by larsbergstrom
We are passing the command as an array, so we need to pre-split the
command into separate words.
Naughtily tested in prod.
This change is