Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd notriddle as reviewer #425
Conversation
|
Let's wait a bit longer. We'll start by delegating when it's appropriate, then grant full reviewer privileges after that. |
|
Yes, in general, there's a bit of a process for adding a reviewer, outlined here: https://github.com/servo/servo/wiki/Governance The big part is, as @jdm mentioned, having somebody review your reviews. We all go through the process, including new full time team members (note that they don't start with r+ privs and often do not get it until a couple of months in!). |
|
Per the governance page, pcwalton and SimonSapin have approved my suggestion to make @notriddle an official reviewer. Congratulations! Be sure to take a look at the reviewer expectations, and feel free to add yourself to the list of random reviewers. |
|
@bors-servo: r+ |
|
|
Add notriddle as reviewer For a couple of PRs now, I've been given permission to review them but not delegated. Let's make this a bit simpler. Should I go in the "operators" list instead? [Somewhat relevant IRC discussion.](http://logs.glob.uno/?c=mozilla%23servo&s=4+Jul+2016&e=5+Jul+2016#c473368) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/425) <!-- Reviewable:end -->
|
@bors-servo retry |
Add notriddle as reviewer For a couple of PRs now, I've been given permission to review them but not delegated. Let's make this a bit simpler. Should I go in the "operators" list instead? [Somewhat relevant IRC discussion.](http://logs.glob.uno/?c=mozilla%23servo&s=4+Jul+2016&e=5+Jul+2016#c473368) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/425) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Add notriddle as reviewer For a couple of PRs now, I've been given permission to review them but not delegated. Let's make this a bit simpler. Should I go in the "operators" list instead? [Somewhat relevant IRC discussion.](http://logs.glob.uno/?c=mozilla%23servo&s=4+Jul+2016&e=5+Jul+2016#c473368) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/425) <!-- Reviewable:end -->
|
What's up with pip? https://travis-ci.org/servo/saltfs/jobs/151266163 |
notriddle commentedJul 5, 2016
•
edited
For a couple of PRs now, I've been given permission to review them but not delegated. Let's make this a bit simpler.
Should I go in the "operators" list instead?
Somewhat relevant IRC discussion.
This change is