Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video-metadata-rs dependencies #428

Merged
merged 1 commit into from Jul 5, 2016
Merged

Add video-metadata-rs dependencies #428

merged 1 commit into from Jul 5, 2016
+4 −0

Conversation

@GuillaumeGomez
Copy link
Contributor

GuillaumeGomez commented Jul 5, 2016 •
edited by larsbergstrom

This change is Reviewable
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jul 5, 2016

cc servo/servo#12186
@notriddle
Copy link
Contributor

notriddle commented Jul 5, 2016

servo-build-dependencies/init.sls, line 13 [r1] (raw file):

      - pkg-config
      - openssl
      - freetype

Don't we need to install these things on macOS as well?

Comments from Reviewable
@notriddle
Copy link
Contributor

notriddle commented Jul 5, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable
@notriddle notriddle self-assigned this Jul 5, 2016
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jul 5, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.

servo-build-dependencies/init.sls, line 13 [r1] (raw file):

Previously, notriddle (Michael Howell) wrote…

Don't we need to install these things on macOS as well?

I'm not sure how to do actually. On my video-metadata-rs crate, I do like this: https://github.com/GuillaumeGomez/video-metadata-rs/blob/master/.travis.yml#L24-L25

Comments from Reviewable
@notriddle
Copy link
Contributor

notriddle commented Jul 5, 2016

servo-build-dependencies/init.sls, line 13 [r1] (raw file):

Previously, GuillaumeGomez (Guillaume Gomez) wrote…

I'm not sure how to do actually. On my video-metadata-rs crate, I do like this: https://github.com/GuillaumeGomez/video-metadata-rs/blob/master/.travis.yml#L24-L25

I'm pretty sure the pkgs list is homebrew packages under mac. But I'm not sure how to do the --with-libvpx argument.

Comments from Reviewable
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jul 5, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.

servo-build-dependencies/init.sls, line 13 [r1] (raw file):

Previously, notriddle (Michael Howell) wrote…

I'm pretty sure the pkgs list is homebrew packages under mac. But I'm not sure how to do the --with-libvpx argument.

That was my point.

Comments from Reviewable
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jul 5, 2016

Thanks to video-metadata-rs/14, we now know we can compile without libvpx.
@GuillaumeGomez
Add video-metadata-rs dependencies
Loading status checks…
bf61ddd
@notriddle
Copy link
Contributor

notriddle commented Jul 5, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@jdm
Copy link
Member

jdm commented Jul 5, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

📌 Commit bf61ddd has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

⌛ Testing commit bf61ddd with merge 8df74a9...
bors-servo added a commit that referenced this pull request Jul 5, 2016
@bors-servo
Auto merge of #428 - GuillaumeGomez:patch-1, r=jdm
Loading status checks…
8df74a9 
Add video-metadata-rs dependencies

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/428)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 5, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit bf61ddd into servo:master Jul 5, 2016
3 checks passed
3 checks passed
code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:patch-1 branch Jul 6, 2016
This was referenced Jul 6, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@GuillaumeGomez @notriddle @jdm @bors-servo
You can’t perform that action at this time.