Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Windows HOME directory to have the proper builder name #441
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
Fix Windows HOME directory to have the proper builder name The change from the builder name of `windows` to `windows-dev` means that many commands were being executed in the incorrect directory. This should fix that! r? @edunham @aneeshusa cc @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/441) <!-- Reviewable:end -->
larsbergstrom
force-pushed the
larsbergstrom:windows_home
branch
from
d04e095
to
78e1df1
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
Fix Windows HOME directory to have the proper builder name The change from the builder name of `windows` to `windows-dev` means that many commands were being executed in the incorrect directory. This should fix that! r? @edunham @aneeshusa cc @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/441) <!-- Reviewable:end -->
larsbergstrom
force-pushed the
larsbergstrom:windows_home
branch
from
890699b
to
10b3823
|
r? @Ms2ger This one finally seemed to pass travis servo-master1 testing :-) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
Fix Windows HOME directory to have the proper builder name The change from the builder name of `windows` to `windows-dev` means that many commands were being executed in the incorrect directory. This should fix that! r? @edunham @aneeshusa cc @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/441) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 23, 2016
…ration-step, r=larsbergstrom Fix `BadConfigurationStep` and return the `try/except` to `DynamicServoFactory` See the commit messages for details and more rationale. Follow-up to #441. r? @larsbergstrom @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/444) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJul 19, 2016
•
edited
The change from the builder name of
windowstowindows-devmeans that many commands were being executed in the incorrect directory. This should fix that!r? @edunham @aneeshusa
cc @Ms2ger
This change is