Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable checking Android build results temporarily #450
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2016
Disable checking Android build results temporarily r? @edunham @aneeshusa @metajack I'd like to temporarily disable checking the results of Android builds. There are two big PRs - an SM upgrade and the move to building on win32 with MSVC that are interdependent. Unfortunately, the SM upgrade also moves to a new Android c++ stdlib, which requires sweeping changes across our submodule builds that partially conflict with MSVC. The easiest way to sequence this (imo) is to land these two PRs with their interdependencies and then I'll pick up the Android pieces immediately after they're in. I'm still allowing Android to build on buildbot so that we get verification as I fix pieces that they're being correctly resolved. cc @vvuk @Ms2ger <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/450) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJul 27, 2016
•
edited
r? @edunham @aneeshusa @metajack
I'd like to temporarily disable checking the results of Android builds.
There are two big PRs - an SM upgrade and the move to building on win32 with MSVC that are interdependent. Unfortunately, the SM upgrade also moves to a new Android c++ stdlib, which requires sweeping changes across our submodule builds that partially conflict with MSVC.
The easiest way to sequence this (imo) is to land these two PRs with their interdependencies and then I'll pick up the Android pieces immediately after they're in.
I'm still allowing Android to build on buildbot so that we get verification as I fix pieces that they're being correctly resolved.
cc @vvuk @Ms2ger
This change is