Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew scripts to nightly #460

Merged
merged 1 commit into from Aug 17, 2016
Merged

Add brew scripts to nightly #460

merged 1 commit into from Aug 17, 2016

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 16, 2016

Follow up of servo/servo#12688

Also, see servo/servo#12888

/cc @larsbergstrom


This change is Reviewable

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 16, 2016

If we're going to make the changes on the saltfs side, we should also add the environment additions. Lemme hack up some quick scripts for that.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 16, 2016

OK, do this:

[larsberg@larsberg saltfs]$ git diff
diff --git a/buildbot/master/files/config/environments.py b/buildbot/master/files/config/environments.py
index de93b59..d8c427f 100644
--- a/buildbot/master/files/config/environments.py
+++ b/buildbot/master/files/config/environments.py
@@ -1,6 +1,6 @@
 import copy

-from passwords import GITHUB_DOC_TOKEN
+from passwords import GITHUB_DOC_TOKEN, GITHUB_HOMEBREW_TOKEN
 from passwords import S3_UPLOAD_ACCESS_KEY_ID, S3_UPLOAD_SECRET_ACCESS_KEY


@@ -136,4 +136,5 @@ build_arm64 = build_arm + Environment({
 upload_nightly = Environment({
     'AWS_ACCESS_KEY_ID': S3_UPLOAD_ACCESS_KEY_ID,
     'AWS_SECRET_ACCESS_KEY': S3_UPLOAD_SECRET_ACCESS_KEY,
+    'TOKEN': GITHUB_HOMEBREW_TOKEN,
 })
diff --git a/buildbot/master/files/config/passwords.py b/buildbot/master/files/config/passwords.py
index 495aedf..3ebcf24 100644
--- a/buildbot/master/files/config/passwords.py
+++ b/buildbot/master/files/config/passwords.py
@@ -3,6 +3,7 @@ HTTP_PASSWORD = "{{ buildbot_credentials['http-pass'] }}"
 SLAVE_PASSWORD = "{{ buildbot_credentials['slave-pass'] }}"
 CHANGE_PASSWORD = "{{ buildbot_credentials['change-pass'] }}"
 GITHUB_DOC_TOKEN = "{{ buildbot_credentials['gh-doc-token'] }}"
+GITHUB_HOMEBREW_TOKEN = "{{ buildbot_credentials['gh-homebrew-token'] }}"
 HOMU_BUILDBOT_SECRET = "{{ buildbot_credentials['homu-secret'] }}"
 S3_UPLOAD_ACCESS_KEY_ID = \
     "{{ buildbot_credentials['s3-upload-access-key-id'] }}"
[larsberg@larsberg saltfs]$ 

Otherwise, the publish will fail.

@paulrouget paulrouget force-pushed the brewScripts branch from 0043283 to d76de1d Aug 17, 2016
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 17, 2016

"All checks have failed"

What am I doing wrong?

@KiChjang
Copy link
Member

KiChjang commented Aug 17, 2016

@paulrouget Not your fault, it looks like pip installation is failing on travis... again.

@aneeshusa
Copy link
Member

aneeshusa commented Aug 17, 2016

This is the same problem with pip; #350 has the fix for it.

@larsbergstrom larsbergstrom merged commit 4bcc684 into master Aug 17, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
bors-servo added a commit that referenced this pull request Aug 18, 2016
…bergstrom

Add fake GitHub homebrew token

Fixes the buildbot master file.recurse failures we've been seeing recently.
Also updates the highstate output to increase the SNR.
See commit messages for details.

Follow-up to #460. This failure was missed because we were experiencing pip failures at the time, causing Travis bustage, and the PR was merged by hand without noticing the additional failures on Travis.

r? @larsbergstrom @edunham

cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/467)
<!-- Reviewable:end -->
@SimonSapin SimonSapin deleted the brewScripts branch Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.