Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colon for python if #465

Merged
merged 1 commit into from Aug 18, 2016
Merged

Add colon for python if #465

merged 1 commit into from Aug 18, 2016

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 18, 2016

r? @edunham

cc @paulrouget


This change is Reviewable

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Aug 18, 2016

This is already deployed.

@aneeshusa
Copy link
Member

aneeshusa commented Aug 18, 2016

r=me (although Travis is failling for unrelated reasons right now)

@aneeshusa
Copy link
Member

aneeshusa commented Aug 18, 2016

Side question @larsbergstrom: how did you deploy this? I didn't see any trace of this code on servo-master1, although it is deployed.

@larsbergstrom larsbergstrom merged commit cd4d529 into servo:master Aug 18, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Aug 18, 2016

Had to manually edit the files in ~servo/buildbot, since we also couldn't highstate so I couldn't do the usual "edit /srv/salt" hackery.

@aneeshusa
Copy link
Member

aneeshusa commented Aug 18, 2016

Right, so as part of #350 the way to make local changes has also changed, /srv/salt is no longer used. See the ADMIN_README file I added in that PR, ask on IRC with any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.