Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd fake GitHub homebrew token #467
Merged
Conversation
We recently added a new homebrew nightly builder, which pushes to the `servo/homebrew-servo` repository to make new binary nightlies available via Homebrew. This requires a Github token to push to the repository. However, the original PR did not include a fake token for the Travis failure, causing the builder to fail only on Travis (where the test pillars did not have the corresponding token), but not in production.
The `state_output: mixed` highstate outputter is more useful than the terse outputter, because the terse outputter always produces only one line of output, but the mixed outputter uses one line for successful states and full output for failed states, increasing the SNR.
|
#465 should be merged first to fix the syntax error. |
|
Also note that the scratch builder is the important Travis result; the other one (that builds the old config then the new config) will fail because the old config is busted. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 18, 2016
…bergstrom Add fake GitHub homebrew token Fixes the buildbot master file.recurse failures we've been seeing recently. Also updates the highstate output to increase the SNR. See commit messages for details. Follow-up to #460. This failure was missed because we were experiencing pip failures at the time, causing Travis bustage, and the PR was merged by hand without noticing the additional failures on Travis. r? @larsbergstrom @edunham cc @paulrouget <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/467) <!-- Reviewable:end -->
|
|
aneeshusa
added
S-awaiting-merge
and removed
S-awaiting-review
S-blocked-on-external
labels
|
@larsbergstrom please larsbors this, the failure is expected since the old config is busted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedAug 18, 2016
•
edited by larsbergstrom
Fixes the buildbot master file.recurse failures we've been seeing recently.
Also updates the highstate output to increase the SNR.
See commit messages for details.
Follow-up to #460. This failure was missed because we were experiencing pip failures at the time, causing Travis bustage, and the PR was merged by hand without noticing the additional failures on Travis.
r? @larsbergstrom @edunham
cc @paulrouget
This change is