This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Add Vagrant version upper bound of "< 1.8.3"#471
Merged
bors-servo merged 1 commit intoservo:masterfrom Aug 23, 2016
Merged
Conversation
A recent PR to Vagrant, which is in released 1.8.3+, breaks our usage of `minion_id` to pass additional args to Salt. See hashicorp/vagrant#7207 for the PR. Also add comments in the Vagrantfile about the version requirements.
aneeshusa
added
S-awaiting-review
S-needs-wiki-changes
and removed
S-needs-wiki-changes
labels
Contributor
Author
Contributor
|
@bors-servo r+ Should we change our code so that 1.8.4 and later work? |
Contributor
|
📌 Commit d12602b has been approved by |
Contributor
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Aug 23, 2016
…ajack Add Vagrant version upper bound of "< 1.8.3" A recent PR to Vagrant, which is in released 1.8.3+, breaks our usage of `minion_id` to pass additional args to Salt. See hashicorp/vagrant#7207 for the PR. Also add comments in the Vagrantfile about the version requirements. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/471) <!-- Reviewable:end -->
Contributor
Author
|
@metajack That would be nice, but Vagrant 1.8.3+ no longer has a way of passing arbitrary args to Salt (at least, that I know of). Being able to use newer versions of Vagrant will require a PR to Vagrant to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent PR to Vagrant, which is in released 1.8.3+, breaks our usage of
minion_idto pass additional args to Salt.See hashicorp/vagrant#7207 for the PR.
Also add comments in the Vagrantfile about the version requirements.
This change is