Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vagrant version upper bound of "< 1.8.3" #471

Merged
merged 1 commit into from Aug 23, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Add Vagrant version upper bound of "< 1.8.3"

A recent PR to Vagrant, which is in released 1.8.3+, breaks our usage of
`minion_id` to pass additional args to Salt.
See hashicorp/vagrant#7207 for the PR.

Also add comments in the Vagrantfile about the version requirements.
  • Loading branch information
aneeshusa committed Aug 22, 2016
commit d12602b9002f24a1e4927917b8f7b87097265ec6
@@ -17,7 +17,11 @@ def is_salt_master(id)
!id.match(/servo-master\d+/).nil?
end

Vagrant.require_version '>= 1.8.0'
# Need Vagrant >= 1.8.0, in which the Vagrant Salt provisioner was overhauled
# See https://github.com/servo/saltfs/pull/180
# Vagrant 1.8.3+ breaks our usage of minion_id to pass additional args to Salt
# See https://github.com/mitchellh/vagrant/pull/7207
Vagrant.require_version('>= 1.8.0', "< 1.8.3")

Vagrant.configure(2) do |config|

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.