Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Homebrew 1.0.0 fallout #483

Merged
merged 9 commits into from Sep 27, 2016

Be robust to upstream changes when building old revs

When running builds that are not from scratch, it is possible that
upstream changes have caused old revisions on master to stop building.
Because homu maintains the invariant that each merge to master is
passing, and we are only building the old revision to create a baseline
to test the new revision, it's safe to ignore failures in the old rev.
  • Loading branch information
aneeshusa committed Sep 24, 2016
commit 09a0e554d5cba0923d9af8ccb8e73bbcfe3bc0e5
@@ -50,7 +50,11 @@ else
else
git fetch origin master:master
git checkout master
# Upstream changes could cause the old rev to fail, so disable errexit
# (homu will maintain the invariant that each rev on master is passing)
set +o errexit
run_salt 'old'
set -o errexit

git checkout "${TRAVIS_COMMIT}"
run_salt 'upgrade'
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.