Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstop metadata.mds service if running in osx #490
Closed
Conversation
|
Thanks for the PR! The commit itself looks great, so here is some review to improve the commit message (see also): Title:
Body:
|
Metadata indexing Service on OS X, indexes files. This causes regular CPU spikes and bad performance on build servers. So disabling the service.
|
@aneeshusa What do you think now? I am no good at writing these kind of stuff. Hope its ok |
|
This is better but there's still room for improvement:
If you're having trouble with the wording, you can also give me access to push to your branch with some suggestions. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vigneshsarma commentedSep 24, 2016
•
edited by larsbergstrom
for issue #445
@aneeshusa creating the PR, to see the tests run.
This change is