Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVagrant: Use `salt_call_args` instead of minion_id #493
Conversation
The hacky `minion_id` method to pass `file-root` and `pillar-root` to `salt-call` does not work since Vagrant 1.8.3. If Vagrant accepts hashicorp/vagrant#7836 , this PR will use the new argument. It also sets the hostname using the appropriate option, superseeding #248. DO NOT MERGE until Vagrant accepts the PR, and releases a new version.
|
@jarondl Thanks for the PR here and to Vagrant! This has actually been on my todo list for a long time. See my feedback on the Vagrant PR. |
|
The upstream PR hashicorp/vagrant#7836 was superseded by hashicorp/vagrant#8927, which has been merged, so this should be available when the next version of Vagrant is released. @jarondl, are you interested in reviving this PR when that happens? It will need to be updated and rebased on top of master, and the docs will need to be updated (the |
|
|
jarondl commentedSep 27, 2016
•
edited by larsbergstrom
The hacky
minion_idmethod to passfile-rootandpillar-roottosalt-calldoes not work since Vagrant 1.8.3.If Vagrant accepts hashicorp/vagrant#7836 , this PR will use the new
argument. It also sets the hostname using the appropriate option,
superseeding #248.
DO NOT MERGE until Vagrant accepts the PR, and releases a new version.
This change is